Mark all functions defined in compiler-builtins as nounwind #121605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be more appropriate to apply |
|
I think it's fine to special case it for now. If we ever want a crate-level attribute then we could revisit this. @bors r+ |
|
This might improve MIR optimizations. I previously found that Queue looks light, so this might be nice to help perf triage: |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2024
Mark all functions defined in compiler-builtins as nounwind Treat functions in compiler-builtins as nounwind. Suggested in rust-lang/compiler-builtins#578 (comment). A prerequisite for rust-lang#116088 r? `@Amanieu` cc `@RalfJung`
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
|
My understanding is that on its own this does nothing since the crate does not set |
|
Hm no that does not seem right; |
|
@bors r- (PR got requeued by sync) |
|
The error is caused by which uses Some options here:
What's the best action here? |
|
FWIW compiler-builtins CI is currently already broken due to #121552. I would just go with option 3. |
|
I believe #122580 will make this PR unnecessary. |
|
The justification I mentioned above still applies: #121605 (comment) |
|
I think this is not needed any more: rust-lang/compiler-builtins#583 landed, so compiler_builtins is now already working fine with proper c_unwind behavior. So, closing the PR (and the commit should be removed from #116088). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat functions in compiler-builtins as nounwind. Suggested in rust-lang/compiler-builtins#578 (comment).
A prerequisite for #116088
r? @Amanieu
cc @RalfJung