Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build rustc with 1CGU on x86_64-apple-darwin #112268

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

lqd
Copy link
Member

@lqd lqd commented Jun 4, 2023

Distribute x86_64-apple-darwin artifacts built with rust.codegen-units=1, like we already do on Linux.

  1. effect on code size on x86_64-apple-darwin: it's a 11.14% reduction on librustc_driver.dylib
  1. time it took on CI:
  1. most recent perf results on (a noisy) x64 mac are here.

Related tracking issue for build configuration: #103595

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 4, 2023
@lqd
Copy link
Member Author

lqd commented Jun 4, 2023

@bors try

@bors
Copy link
Contributor

bors commented Jun 4, 2023

⌛ Trying commit 6ac543414ae34aa0ef4fb46d5978442bce42adc1 with merge 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75...

@bors
Copy link
Contributor

bors commented Jun 4, 2023

☀️ Try build successful - checks-actions
Build commit: 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75 (14c00943af8fc8297afbcf5d8a4d2cc0abb02e75)

1 similar comment
@bors
Copy link
Contributor

bors commented Jun 4, 2023

☀️ Try build successful - checks-actions
Build commit: 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75 (14c00943af8fc8297afbcf5d8a4d2cc0abb02e75)

@lqd
Copy link
Member Author

lqd commented Jun 4, 2023

Locally on an aarch64-apple-darwin M1, using 1 CGU looks like this via rcb (w/ 2 baseline runs, to show the system noise):

benchmark baseline baseline noise baseline noise % 1CGU 1CGU %
clap:check 0.6678s 0.6683s +0.07% 0.6407s -4.06%
clap:check:initial 0.8064s 0.8047s -0.21% 0.7731s -4.13%
clap:check:unchanged 0.1737s 0.1737s -0.01% 0.1691s -2.67%
hyper:check 0.0980s 0.0973s -0.80% 0.0919s -6.23%
hyper:check:initial 0.1275s 0.1275s -0.05% 0.1226s -3.87%
hyper:check:unchanged 0.0531s 0.0529s -0.48% 0.0500s -5.87%
regex:check 0.3678s 0.3683s +0.14% 0.3529s -4.04%
regex:check:initial 0.4586s 0.4593s +0.16% 0.4405s -3.94%
regex:check:unchanged 0.1284s 0.1285s +0.10% 0.1246s -2.94%
syn:check 0.6108s 0.6106s -0.03% 0.5876s -3.79%
syn:check:initial 0.7596s 0.7590s -0.08% 0.7334s -3.46%
syn:check:unchanged 0.2347s 0.2330s -0.76% 0.2281s -2.83%
syntex_syntax:check 2.2357s 2.2401s +0.20% 2.1504s -3.82%
syntex_syntax:check:initial 2.7605s 2.7637s +0.12% 2.6673s -3.38%
syntex_syntax:check:unchanged 0.6608s 0.6631s +0.35% 0.6455s -2.32%
Total 10.1437s 10.1501s +0.06% 9.7778s -3.61%
Summary 5.0000s 4.9957s -0.09% 4.8088s -3.82%

@lqd
Copy link
Member Author

lqd commented Jun 4, 2023

And on an old noisy x86_64-apple-darwin iMac, a few hyperfine runs on some of rcb's clean check benchmarks, with their dependencies. (I can't easily run it on try toolchains)

  • clap (noisy):
Benchmark 1: baseline try-parent 9eee230cd0a56bfba3ce65121798d9f9f4341cdd cargo check -j4
  Time (mean ± σ):     12.300 s ±  0.648 s    [User: 25.793 s, System: 3.245 s]
  Range (min … max):   11.850 s … 13.043 s    3 runs
 
Benchmark 2: try 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75 cargo check -j4 with 1CGU rustc
  Time (mean ± σ):     11.230 s ±  0.052 s    [User: 25.170 s, System: 3.218 s]
  Range (min … max):   11.177 s … 11.281 s    3 runs
 
Summary
  'try 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75 cargo check -j4 with 1CGU rustc' ran
    1.10 ± 0.06 times faster than 'baseline try-parent 9eee230cd0a56bfba3ce65121798d9f9f4341cdd cargo check -j4'
  • helloworld:
Benchmark 1: baseline try-parent 9eee230cd0a56bfba3ce65121798d9f9f4341cdd cargo check -j4
  Time (mean ± σ):     212.0 ms ±   0.5 ms    [User: 86.4 ms, System: 72.7 ms]
  Range (min … max):   211.5 ms … 212.4 ms    3 runs
 
Benchmark 2: try 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75 cargo check -j4 with 1CGU rustc
  Time (mean ± σ):     201.2 ms ±   0.5 ms    [User: 82.0 ms, System: 68.0 ms]
  Range (min … max):   200.7 ms … 201.7 ms    3 runs
 
Summary
  'try 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75 cargo check -j4 with 1CGU rustc' ran
    1.05 ± 0.00 times faster than 'baseline try-parent 9eee230cd0a56bfba3ce65121798d9f9f4341cdd cargo check -j4'
  • hyper:
Benchmark 1: baseline try-parent 9eee230cd0a56bfba3ce65121798d9f9f4341cdd cargo check -j4
  Time (mean ± σ):     12.111 s ±  0.390 s    [User: 27.421 s, System: 3.109 s]
  Range (min … max):   11.847 s … 12.560 s    3 runs
 
Benchmark 2: try 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75 cargo check -j4 with 1CGU rustc
  Time (mean ± σ):     11.571 s ±  0.126 s    [User: 26.653 s, System: 3.086 s]
  Range (min … max):   11.427 s … 11.656 s    3 runs
 
Summary
  'try 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75 cargo check -j4 with 1CGU rustc' ran
    1.05 ± 0.04 times faster than 'baseline try-parent 9eee230cd0a56bfba3ce65121798d9f9f4341cdd cargo check -j4'
  • regex:
Benchmark 1: baseline try-parent 9eee230cd0a56bfba3ce65121798d9f9f4341cdd cargo check -j4
  Time (mean ± σ):      3.369 s ±  0.067 s    [User: 4.040 s, System: 0.545 s]
  Range (min … max):    3.292 s …  3.413 s    3 runs
 
Benchmark 2: try 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75 cargo check -j4 with 1CGU rustc
  Time (mean ± σ):      3.233 s ±  0.049 s    [User: 3.855 s, System: 0.534 s]
  Range (min … max):    3.199 s …  3.289 s    3 runs
 
Summary
  'try 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75 cargo check -j4 with 1CGU rustc' ran
    1.04 ± 0.03 times faster than 'baseline try-parent 9eee230cd0a56bfba3ce65121798d9f9f4341cdd cargo check -j4'
  • syn:
Benchmark 1: baseline try-parent 9eee230cd0a56bfba3ce65121798d9f9f4341cdd cargo check -j4
  Time (mean ± σ):      2.776 s ±  0.026 s    [User: 2.752 s, System: 0.587 s]
  Range (min … max):    2.749 s …  2.802 s    3 runs
 
Benchmark 2: try 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75 cargo check -j4 with 1CGU rustc
  Time (mean ± σ):      2.676 s ±  0.043 s    [User: 2.662 s, System: 0.583 s]
  Range (min … max):    2.646 s …  2.725 s    3 runs
 
Summary
  'try 14c00943af8fc8297afbcf5d8a4d2cc0abb02e75 cargo check -j4 with 1CGU rustc' ran
    1.04 ± 0.02 times faster than 'baseline try-parent 9eee230cd0a56bfba3ce65121798d9f9f4341cdd cargo check -j4'

@lqd
Copy link
Member Author

lqd commented Jul 13, 2023

We were interested in the effect on code size on x86_64-apple-darwin: it's a 11% reduction on librustc_driver.dylib (it's unclear how much of that is on debuginfo, if any)

@Dylan-DPC Dylan-DPC added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023
@lqd
Copy link
Member Author

lqd commented Sep 5, 2023

@bors try

@bors
Copy link
Contributor

bors commented Sep 5, 2023

⌛ Trying commit f4bdeec with merge 884d017364f6a089eaa586259bb66040ece4ec20...

@bors
Copy link
Contributor

bors commented Sep 5, 2023

☀️ Try build successful - checks-actions
Build commit: 884d017364f6a089eaa586259bb66040ece4ec20 (884d017364f6a089eaa586259bb66040ece4ec20)

@lqd
Copy link
Member Author

lqd commented Sep 5, 2023

1h52.

Let's try again, @bors try

@lqd

This comment was marked as resolved.

@bors
Copy link
Contributor

bors commented Sep 5, 2023

⌛ Trying commit f4bdeec with merge dcb21d731134b829241aaa8797e94c33efab2d3c...

@bors
Copy link
Contributor

bors commented Sep 5, 2023

☀️ Try build successful - checks-actions
Build commit: dcb21d731134b829241aaa8797e94c33efab2d3c (dcb21d731134b829241aaa8797e94c33efab2d3c)

@lqd
Copy link
Member Author

lqd commented Sep 5, 2023

1h29

@lqd
Copy link
Member Author

lqd commented Mar 5, 2024

@bors try

@bors
Copy link
Contributor

bors commented Mar 5, 2024

⌛ Trying commit 4296eae with merge 7549dbd...

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2024
Build `rustc` with 1CGU on `x86_64-apple-darwin`

Part of the sanity checks for building rustc with 1CGU everywhere:

- if the `dist-x86_64-apple` builder doesn't timeout
- how the resulting artifacts perform on `x86_64-apple-darwin`

r? `@ghost`
@bors
Copy link
Contributor

bors commented Mar 5, 2024

☀️ Try build successful - checks-actions
Build commit: 7549dbd (7549dbdc09f0c4f6cc84002ac03081828054784b)

@bors
Copy link
Contributor

bors commented Mar 5, 2024

☀️ Try build successful - checks-actions
Build commit: 399d8a4 (399d8a4eabbd579208ecef3e9f14f7973ebadecc)

@lqd
Copy link
Member Author

lqd commented Mar 5, 2024

We were interested in

  1. the effect on code size on x86_64-apple-darwin: it's a 11.14% reduction on librustc_driver.dylib
  1. the time it took on CI:

@lqd lqd marked this pull request as ready for review March 5, 2024 17:04
@lqd
Copy link
Member Author

lqd commented Mar 5, 2024

This may need some discussion within t-infra so I'll r? @Kobzol and let him ping others if needed, once he's happy after review.

@Kobzol
Copy link
Contributor

Kobzol commented Mar 11, 2024

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Mar 11, 2024

📌 Commit b36fa70 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 11, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2024
Build `rustc` with 1CGU on `x86_64-apple-darwin`

Distribute `x86_64-apple-darwin` artifacts built with `rust.codegen-units=1`, like we already do on Linux.

1) effect on code size on `x86_64-apple-darwin`: it's a 11.14% reduction on `librustc_driver.dylib`
- before, [`41d97c8a5dea2731b0e56fe97cd7cb79e21cff79`](https://ci-artifacts.rust-lang.org/rustc-builds/41d97c8a5dea2731b0e56fe97cd7cb79e21cff79/rustc-nightly-x86_64-apple-darwin.tar.xz): 161232048
- after, [`7549dbdc09f0c4f6cc84002ac03081828054784b`](https://ci-artifacts.rust-lang.org/rustc-builds/7549dbdc09f0c4f6cc84002ac03081828054784b/rustc-nightly-x86_64-apple-darwin.tar.xz): 143256928

2) time it took on CI:
- the [first `try` build](https://github.com/rust-lang-ci/rust/actions/runs/8155512915/job/22291187124) took: 1h 33m
- the [second `try` build](https://github.com/rust-lang-ci/rust/actions/runs/8157057880/job/22295839911) took: 1h 45m

3) most recent perf results on (a noisy) x64 mac are [here](rust-lang#112268 (comment)).

Related tracking issue for build configuration: rust-lang#103595
@bors
Copy link
Contributor

bors commented Mar 11, 2024

⌛ Testing commit b36fa70 with merge 37ba5f4...

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] rustc_codegen_llvm test:false 66.982
   Compiling rustc_mir_transform v0.0.0 (/checkout/compiler/rustc_mir_transform)
[RUSTC-TIMING] rustc_traits test:false 17.413
   Compiling rustc_hir_typeck v0.0.0 (/checkout/compiler/rustc_hir_typeck)
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
##[group]Clock drift check
  local time: Tue Mar 12 00:01:55 UTC 2024
  network time: Tue, 12 Mar 2024 00:01:55 GMT
##[endgroup]
##[endgroup]
Session terminated, killing shell... ...killed.
##[error]The operation was canceled.

@bors
Copy link
Contributor

bors commented Mar 12, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2024
@lqd
Copy link
Member Author

lqd commented Mar 12, 2024

@bors retry The runner has received a shutdown signal

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2024
@bors
Copy link
Contributor

bors commented Mar 12, 2024

⌛ Testing commit b36fa70 with merge 5aad51d...

@bors
Copy link
Contributor

bors commented Mar 12, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 5aad51d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 12, 2024
@bors bors merged commit 5aad51d into rust-lang:master Mar 12, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 12, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5aad51d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [0.1%, 2.5%] 2
Regressions ❌
(secondary)
5.5% [5.5%, 5.5%] 1
Improvements ✅
(primary)
-3.4% [-3.4%, -3.4%] 1
Improvements ✅
(secondary)
-2.8% [-2.8%, -2.8%] 1
All ❌✅ (primary) -0.3% [-3.4%, 2.5%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.9% [1.8%, 2.0%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.9% [-2.9%, -2.9%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.134s -> 672.319s (0.03%)
Artifact size: 310.00 MiB -> 310.04 MiB (0.01%)

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Mar 12, 2024
Build `rustc` with 1CGU on `x86_64-apple-darwin`

Distribute `x86_64-apple-darwin` artifacts built with `rust.codegen-units=1`, like we already do on Linux.

1) effect on code size on `x86_64-apple-darwin`: it's a 11.14% reduction on `librustc_driver.dylib`
- before, [`41d97c8a5dea2731b0e56fe97cd7cb79e21cff79`](https://ci-artifacts.rust-lang.org/rustc-builds/41d97c8a5dea2731b0e56fe97cd7cb79e21cff79/rustc-nightly-x86_64-apple-darwin.tar.xz): 161232048
- after, [`7549dbdc09f0c4f6cc84002ac03081828054784b`](https://ci-artifacts.rust-lang.org/rustc-builds/7549dbdc09f0c4f6cc84002ac03081828054784b/rustc-nightly-x86_64-apple-darwin.tar.xz): 143256928

2) time it took on CI:
- the [first `try` build](https://github.com/rust-lang-ci/rust/actions/runs/8155512915/job/22291187124) took: 1h 33m
- the [second `try` build](https://github.com/rust-lang-ci/rust/actions/runs/8157057880/job/22295839911) took: 1h 45m

3) most recent perf results on (a noisy) x64 mac are [here](rust-lang/rust#112268 (comment)).

Related tracking issue for build configuration: #103595
@lqd lqd deleted the osx-1cgu branch March 12, 2024 07:25
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 7, 2024
Build `rustc` with 1CGU on `x86_64-apple-darwin`

Distribute `x86_64-apple-darwin` artifacts built with `rust.codegen-units=1`, like we already do on Linux.

1) effect on code size on `x86_64-apple-darwin`: it's a 11.14% reduction on `librustc_driver.dylib`
- before, [`41d97c8a5dea2731b0e56fe97cd7cb79e21cff79`](https://ci-artifacts.rust-lang.org/rustc-builds/41d97c8a5dea2731b0e56fe97cd7cb79e21cff79/rustc-nightly-x86_64-apple-darwin.tar.xz): 161232048
- after, [`7549dbdc09f0c4f6cc84002ac03081828054784b`](https://ci-artifacts.rust-lang.org/rustc-builds/7549dbdc09f0c4f6cc84002ac03081828054784b/rustc-nightly-x86_64-apple-darwin.tar.xz): 143256928

2) time it took on CI:
- the [first `try` build](https://github.com/rust-lang-ci/rust/actions/runs/8155512915/job/22291187124) took: 1h 33m
- the [second `try` build](https://github.com/rust-lang-ci/rust/actions/runs/8157057880/job/22295839911) took: 1h 45m

3) most recent perf results on (a noisy) x64 mac are [here](rust-lang/rust#112268 (comment)).

Related tracking issue for build configuration: #103595
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
Build `rustc` with 1CGU on `x86_64-apple-darwin`

Distribute `x86_64-apple-darwin` artifacts built with `rust.codegen-units=1`, like we already do on Linux.

1) effect on code size on `x86_64-apple-darwin`: it's a 11.14% reduction on `librustc_driver.dylib`
- before, [`41d97c8a5dea2731b0e56fe97cd7cb79e21cff79`](https://ci-artifacts.rust-lang.org/rustc-builds/41d97c8a5dea2731b0e56fe97cd7cb79e21cff79/rustc-nightly-x86_64-apple-darwin.tar.xz): 161232048
- after, [`7549dbdc09f0c4f6cc84002ac03081828054784b`](https://ci-artifacts.rust-lang.org/rustc-builds/7549dbdc09f0c4f6cc84002ac03081828054784b/rustc-nightly-x86_64-apple-darwin.tar.xz): 143256928

2) time it took on CI:
- the [first `try` build](https://github.com/rust-lang-ci/rust/actions/runs/8155512915/job/22291187124) took: 1h 33m
- the [second `try` build](https://github.com/rust-lang-ci/rust/actions/runs/8157057880/job/22295839911) took: 1h 45m

3) most recent perf results on (a noisy) x64 mac are [here](rust-lang/rust#112268 (comment)).

Related tracking issue for build configuration: #103595
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request May 4, 2024
Pkgsrc changes:
 * Adapt checksums and patches, some have beene intregrated upstream.

Upstream chnages:

Version 1.78.0 (2024-05-02)
===========================

Language
--------
- [Stabilize `#[cfg(target_abi = ...)]`]
  (rust-lang/rust#119590)
- [Stabilize the `#[diagnostic]` namespace and
  `#[diagnostic::on_unimplemented]` attribute]
  (rust-lang/rust#119888)
- [Make async-fn-in-trait implementable with concrete signatures]
  (rust-lang/rust#120103)
- [Make matching on NaN a hard error, and remove the rest of
  `illegal_floating_point_literal_pattern`]
  (rust-lang/rust#116284)
- [static mut: allow mutable reference to arbitrary types, not just
  slices and arrays]
  (rust-lang/rust#117614)
- [Extend `invalid_reference_casting` to include references casting
  to bigger memory layout]
  (rust-lang/rust#118983)
- [Add `non_contiguous_range_endpoints` lint for singleton gaps
  after exclusive ranges]
  (rust-lang/rust#118879)
- [Add `wasm_c_abi` lint for use of older wasm-bindgen versions]
  (rust-lang/rust#117918)
  This lint currently only works when using Cargo.
- [Update `indirect_structural_match` and `pointer_structural_match`
  lints to match RFC]
  (rust-lang/rust#120423)
- [Make non-`PartialEq`-typed consts as patterns a hard error]
  (rust-lang/rust#120805)
- [Split `refining_impl_trait` lint into `_reachable`, `_internal` variants]
  (rust-lang/rust#121720)
- [Remove unnecessary type inference when using associated types
  inside of higher ranked `where`-bounds]
  (rust-lang/rust#119849)
- [Weaken eager detection of cyclic types during type inference]
  (rust-lang/rust#119989)
- [`trait Trait: Auto {}`: allow upcasting from `dyn Trait` to `dyn Auto`]
  (rust-lang/rust#119338)

Compiler
--------

- [Made `INVALID_DOC_ATTRIBUTES` lint deny by default]
  (rust-lang/rust#111505)
- [Increase accuracy of redundant `use` checking]
  (rust-lang/rust#117772)
- [Suggest moving definition if non-found macro_rules! is defined later]
  (rust-lang/rust#121130)
- [Lower transmutes from int to pointer type as gep on null]
  (rust-lang/rust#121282)

Target changes:

- [Windows tier 1 targets now require at least Windows 10]
  (rust-lang/rust#115141)
 - [Enable CMPXCHG16B, SSE3, SAHF/LAHF and 128-bit Atomics in tier 1 Windows]
  (rust-lang/rust#120820)
- [Add `wasm32-wasip1` tier 2 (without host tools) target]
  (rust-lang/rust#120468)
- [Add `wasm32-wasip2` tier 3 target]
  (rust-lang/rust#119616)
- [Rename `wasm32-wasi-preview1-threads` to `wasm32-wasip1-threads`]
  (rust-lang/rust#122170)
- [Add `arm64ec-pc-windows-msvc` tier 3 target]
  (rust-lang/rust#119199)
- [Add `armv8r-none-eabihf` tier 3 target for the Cortex-R52]
  (rust-lang/rust#110482)
- [Add `loongarch64-unknown-linux-musl` tier 3 target]
  (rust-lang/rust#121832)

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

Libraries
---------

- [Bump Unicode to version 15.1.0, regenerate tables]
  (rust-lang/rust#120777)
- [Make align_offset, align_to well-behaved in all cases]
  (rust-lang/rust#121201)
- [PartialEq, PartialOrd: document expectations for transitive chains]
  (rust-lang/rust#115386)
- [Optimize away poison guards when std is built with panic=abort]
  (rust-lang/rust#100603)
- [Replace pthread `RwLock` with custom implementation]
  (rust-lang/rust#110211)
- [Implement unwind safety for Condvar on all platforms]
  (rust-lang/rust#121768)
- [Add ASCII fast-path for `char::is_grapheme_extended`]
  (rust-lang/rust#121138)

Stabilized APIs
---------------

- [`impl Read for &Stdin`]
  (https://doc.rust-lang.org/stable/std/io/struct.Stdin.html#impl-Read-for-%26Stdin)
- [Accept non `'static` lifetimes for several `std::error::Error`
  related implementations] (rust-lang/rust#113833)
- [Make `impl<Fd: AsFd>` impl take `?Sized`]
  (rust-lang/rust#114655)
- [`impl From<TryReserveError> for io::Error`]
  (https://doc.rust-lang.org/stable/std/io/struct.Error.html#impl-From%3CTryReserveError%3E-for-Error)

These APIs are now stable in const contexts:

- [`Barrier::new()`]
  (https://doc.rust-lang.org/stable/std/sync/struct.Barrier.html#method.new)

Cargo
-----

- [Stabilize lockfile v4](rust-lang/cargo#12852)
- [Respect `rust-version` when generating lockfile]
  (rust-lang/cargo#12861)
- [Control `--charset` via auto-detecting config value]
  (rust-lang/cargo#13337)
- [Support `target.<triple>.rustdocflags` officially]
  (rust-lang/cargo#13197)
- [Stabilize global cache data tracking]
  (rust-lang/cargo#13492)

Misc
----

- [rustdoc: add `--test-builder-wrapper` arg to support wrappers
  such as RUSTC_WRAPPER when building doctests]
  (rust-lang/rust#114651)

Compatibility Notes
-------------------

- [Many unsafe precondition checks now run for user code with debug
  assertions enabled] (rust-lang/rust#120594)
  This change helps users catch undefined behavior in their code,
  though the details of how much is checked are generally not
  stable.
- [riscv only supports split_debuginfo=off for now]
  (rust-lang/rust#120518)
- [Consistently check bounds on hidden types of `impl Trait`]
  (rust-lang/rust#121679)
- [Change equality of higher ranked types to not rely on subtyping]
  (rust-lang/rust#118247)
- [When called, additionally check bounds on normalized function return type]
  (rust-lang/rust#118882)
- [Expand coverage for `arithmetic_overflow` lint]
  (rust-lang/rust#119432)

Internal Changes
----------------

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.

- [Update to LLVM 18](rust-lang/rust#120055)
- [Build `rustc` with 1CGU on `x86_64-pc-windows-msvc`]
  (rust-lang/rust#112267)
- [Build `rustc` with 1CGU on `x86_64-apple-darwin`]
  (rust-lang/rust#112268)
- [Introduce `run-make` V2 infrastructure, a `run_make_support`
  library and port over 2 tests as example]
  (rust-lang/rust#113026)
- [Windows: Implement condvar, mutex and rwlock using futex]
  (rust-lang/rust#121956)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants