Migrate diagnostics in rustc_borrowck
#104055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
|
r? @davidtwco |
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
|
Could you please rename your PR to something more descriptive? I have a hard time understanding what it means. Thanks :) |
|
thank you Michael for helping out🙇 @fmease ,I'm sorry for the trouble caused, I'll keep that in mind. Here is a description of this PR: It's one big nested diagnose to me, |
AndyJado
commented
Nov 8, 2022
.../ui/closures/2229_closure_analysis/diagnostics/borrowck/borrowck-closures-mut-and-imm.stderr
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
7fc677b
to
f99933c
Compare
davidtwco
requested changes
Nov 23, 2022
.../ui/closures/2229_closure_analysis/diagnostics/borrowck/borrowck-closures-mut-and-imm.stderr
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
202e948
to
a33f7a8
Compare
|
⌛ Testing commit e5adc1de21bb0ccb27a874c2a46e129dc8f67d6d with merge 1d5efc7ace6b7ead9c0f72d445c55b3b7874f69b... |
|
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Seems spurious.. @bors retry |
|
⌛ Testing commit e5adc1de21bb0ccb27a874c2a46e129dc8f67d6d with merge 31f515e72096e9a2a3d0f98bc8cbf1dbb5ec5913... |
|
💔 Test failed - checks-actions |
|
umbrella warning is not showing, but merge conflict occurs locally, I rebased and tested and pushed. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors r+ |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#104055 (Migrate diagnostics in `rustc_borrowck`) - rust-lang#110257 (fix false positives for `unused_parens` around unary and binary operations) - rust-lang#110313 (allow `repr(align = x)` on inherent methods) - rust-lang#110337 (Correct default value for default-linker-libraries) - rust-lang#110386 (Clean up traversal macros) - rust-lang#110394 (Various minor Idx-related tweaks) - rust-lang#110425 (Encode def span for `ConstParam`) - rust-lang#110434 (Check freeze with right param-env in `deduced_param_attrs`) - rust-lang#110455 (tests: adapt for LLVM change 5b386b8) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry for making a new PR, #103559 and #103960.
I am crawling, joyfully.