Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using in_band_lifetimes in compiler crates #91867

Closed
21 tasks done
scottmcm opened this issue Dec 13, 2021 · 11 comments
Closed
21 tasks done

Stop using in_band_lifetimes in compiler crates #91867

scottmcm opened this issue Dec 13, 2021 · 11 comments
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@scottmcm
Copy link
Member

scottmcm commented Dec 13, 2021 •
edited
Loading

With more than 50% of the sign-offs needed in #44524 (comment) to remove the feature entirely (EDIT: And now in FCP), I think it's now fine to start updating the compiler code to stop using the nightly feature.

Here are the crates currently using it:

I've marked this E-easy as it's very mechanical work. If you're interested in helping out:

  • Get your dev environment set up so that you can successfully build the compiler, see https://rustc-dev-guide.rust-lang.org/
  • Post the crate you'll tackle, to avoid duplicate work. (I suggest picking ~randomly, not going in order.)
  • Delete the #![feature(in_band_lifetimes)] line from the lib.rs file
  • Look at the compiler errors, and either
    • See that the undeclared lifetime is single-use, and thus replace it with '_, or
    • If it's used multiple times, declare it at the appropriate scope.
  • Once it compiles again, review the git diff to ensure it has only lifetime annotation changes.
  • EDIT: Remember to run x.py fmt and x.py test tidy!
  • Send a PR cc'ing this issue, and edit your previous post to include the PR number.

If you'd like to see how these PRs end up looking, here's two that I made earlier:

(They're also listed in the checklist above.)
@scottmcm scottmcm added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2021
@LegionMammal978
Copy link
Contributor

LegionMammal978 commented Dec 13, 2021 •
edited
Loading

I've worked on rustc_infer (#91878), rustc_codegen_ssa (#91885), rustc_const_eval (#91887), rustc_mir_dataflow (#91922), rustc_query_impl (#91923), rustc_privacy (#91925), and rustc_codegen_llvm (#91931).

@camelid camelid added the E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. label Dec 13, 2021
@LegionMammal978 LegionMammal978 mentioned this issue Dec 13, 2021
Merged
@bugadani
Copy link
Contributor

bugadani commented Dec 13, 2021 •
edited
Loading

I can give rustc_borrowck a try (#91879)

@bugadani bugadani mentioned this issue Dec 13, 2021
Merged
@Patrick-Poitras
Copy link
Contributor

Patrick-Poitras commented Dec 14, 2021 •
edited
Loading

I'll try with rustc_typeck. 243 errors fixed! (#91882)

@Patrick-Poitras Patrick-Poitras mentioned this issue Dec 14, 2021
Merged
@LegionMammal978 LegionMammal978 mentioned this issue Dec 14, 2021
Merged
@LegionMammal978 LegionMammal978 mentioned this issue Dec 14, 2021
Merged
LegionMammal978 added a commit to LegionMammal978/rust that referenced this issue Dec 14, 2021
@LegionMammal978
Remove in_band_lifetimes from rustc_const_eval
a19eaf3 
See rust-lang#91867 for more information.
@LegionMammal978 LegionMammal978 mentioned this issue Dec 14, 2021
Closed
@pitaj
Copy link
Contributor

pitaj commented Dec 14, 2021 •
edited
Loading

I'll take rustc_hir (#91893) and rustc_incremental (#91894).

I'll also take rustc_monomorphize (#91895) and rustc_passes (#91896).

This was referenced Dec 14, 2021
Merged
Merged
Merged
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 14, 2021
@matthiaskrgr
Rollup merge of rust-lang#91879 - bugadani:in_band_borrowck, r=wesley…
d33e4da 
…wiser

Remove `in_band_lifetimes` from `rustc_borrowck`

See rust-lang#91867 for more information.
@SylvanB
Copy link
Contributor

SylvanB commented Dec 14, 2021 •
edited
Loading

I'll take rustc_symbol_mangling (#91901).
Also taking rustc_trait_selection (#91904).
Also taking rustc_metadata (#91926)

@SylvanB SylvanB mentioned this issue Dec 14, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 14, 2021
@matthiaskrgr
Rollup merge of rust-lang#91887 - LegionMammal978:less-inband-const_e…
3a42dc8 
…val, r=oli-obk

Remove `in_band_lifetimes` from `rustc_const_eval`

See rust-lang#91867 for more information.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 14, 2021
@matthiaskrgr
Rollup merge of rust-lang#91893 - pitaj:91867-hir, r=davidtwco
1dde0db 
Remove `in_band_lifetimes` from `rustc_hir`

rust-lang#91867
@SylvanB SylvanB mentioned this issue Dec 14, 2021
Merged
@lameferret
Copy link
Contributor

lameferret commented Dec 14, 2021 •
edited
Loading

will try library\proc_macro, PR: #91906

also compiler\rustc_traits, PR: #91929

compiler\rustc_trait_selection, PR: #91927

compiler\rustc_middle : Having a hard time with this one, if anyone wants they can pick it up.

@lameferret lameferret mentioned this issue Dec 14, 2021
Merged
LegionMammal978 added a commit to LegionMammal978/rust that referenced this issue Dec 14, 2021
@LegionMammal978
Remove in_band_lifetimes from rustc_trait_selection
8bf4964 
See rust-lang#91867 for more information.
LegionMammal978 added a commit to LegionMammal978/rust that referenced this issue Dec 16, 2021
@LegionMammal978
Remove in_band_lifetimes from rustc_mir_dataflow
fed881a 
See rust-lang#91867 for more information.
LegionMammal978 added a commit to LegionMammal978/rust that referenced this issue Dec 16, 2021
@LegionMammal978
Remove in_band_lifetimes from rustc_codegen_llvm
4937a55 
See rust-lang#91867 for more information.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 17, 2021
@matthiaskrgr
Rollup merge of rust-lang#91896 - pitaj:91867-passes, r=michaelwoerister
3379500 
Remove `in_band_lifetimes` for `rustc_passes`

rust-lang#91867
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 17, 2021
@matthiaskrgr
Rollup merge of rust-lang#91923 - LegionMammal978:less-inband-query_i…
3908da8 
…mpl, r=michaelwoerister

Remove `in_band_lifetimes` from `rustc_query_impl`

See rust-lang#91867 for more information.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 17, 2021
@matthiaskrgr
Rollup merge of rust-lang#91896 - pitaj:91867-passes, r=michaelwoerister
44f358b 
Remove `in_band_lifetimes` for `rustc_passes`

rust-lang#91867
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 17, 2021
@matthiaskrgr
Rollup merge of rust-lang#91923 - LegionMammal978:less-inband-query_i…
86fe070 
…mpl, r=michaelwoerister

Remove `in_band_lifetimes` from `rustc_query_impl`

See rust-lang#91867 for more information.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#91896 - pitaj:91867-passes, r=michaelwoerister
a5732ac 
Remove `in_band_lifetimes` for `rustc_passes`

rust-lang#91867
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#91922 - LegionMammal978:less-inband-mir_dat…
91d3b73 
…aflow, r=nagisa

Remove `in_band_lifetimes` from `rustc_mir_dataflow`

See rust-lang#91867 for more information.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#91896 - pitaj:91867-passes, r=michaelwoerister
d31cfe4 
Remove `in_band_lifetimes` for `rustc_passes`

rust-lang#91867
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#91922 - LegionMammal978:less-inband-mir_dat…
d2f2f0b 
…aflow, r=nagisa

Remove `in_band_lifetimes` from `rustc_mir_dataflow`

See rust-lang#91867 for more information.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#91896 - pitaj:91867-passes, r=michaelwoerister
eb3cc13 
Remove `in_band_lifetimes` for `rustc_passes`

rust-lang#91867
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#91923 - LegionMammal978:less-inband-query_i…
df42891 
…mpl, r=michaelwoerister

Remove `in_band_lifetimes` from `rustc_query_impl`

See rust-lang#91867 for more information.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#91925 - LegionMammal978:less-inband-privacy…
44ff0f7 
…, r=nagisa

Remove `in_band_lifetimes` from `rustc_privacy`

See rust-lang#91867 for more information.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#91926 - SylvanB:remove_in_band_lifetimes_fr…
9e720a8 
…om_rustc_metadata, r=nagisa

Remove `in_band_lifetimes` from `rustc_metadata`

Another for rust-lang#91867
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#91931 - LegionMammal978:less-inband-codegen…
ca3d129 
…_llvm, r=davidtwco

Remove `in_band_lifetimes` from `rustc_codegen_llvm`

See rust-lang#91867 for more information.

This one took a while. This crate has dozens of functions not associated with any type, and most of them were using in-band lifetimes for `'ll` and `'tcx`.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#91894 - pitaj:91867-incremental, r=Aaron1011
b19609b 
Remove `in_band_lifetimes` from `rustc_incremental`

rust-lang#91867
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#91894 - pitaj:91867-incremental, r=Aaron1011
8039087 
Remove `in_band_lifetimes` from `rustc_incremental`

rust-lang#91867
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 19, 2021
@matthiaskrgr
Rollup merge of rust-lang#91984 - Aaron1011:rustc-middle-lifetime, r=…
4d5ffc4 
…oli-obk

Remove `in_band_lifetimes` from `rustc_middle`

See rust-lang#91867

This was mostly straightforward. In several places, I take advantage
of the fact that lifetimes are non-hygenic: a macro declares the
'tcx' lifetime, which is then used in types passed in as macro
arguments.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 19, 2021
@matthiaskrgr
Rollup merge of rust-lang#91878 - LegionMammal978:less-inband-infer, …
d576f7d 
…r=Aaron1011

Remove `in_band_lifetimes` from `rustc_infer`

See rust-lang#91867 for more information.

This crate actually had a typo `'ctx` in one of its functions:
```diff
-pub fn same_type_modulo_infer(a: Ty<'tcx>, b: Ty<'ctx>) -> bool {
+pub fn same_type_modulo_infer<'tcx>(a: Ty<'tcx>, b: Ty<'tcx>) -> bool {
```
Also, I wasn't entirely sure about the lifetimes in `suggest_new_region_bound`:
```diff
 pub fn suggest_new_region_bound(
-    tcx: TyCtxt<'tcx>,
+    tcx: TyCtxt<'_>,
     err: &mut DiagnosticBuilder<'_>,
     fn_returns: Vec<&rustc_hir::Ty<'_>>,
```
Should all of those lifetimes really be distinct?
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 19, 2021
@matthiaskrgr
Rollup merge of rust-lang#91895 - pitaj:91867-monomorphize, r=Aaron1011
fba0d04 
Remove `in_band_lifetimes` for `rustc_monomorphize`

rust-lang#91867
@camelid camelid mentioned this issue Dec 28, 2021
Closed
@camsteffen camsteffen mentioned this issue Dec 28, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 31, 2021
@bors
Auto merge of rust-lang#91929 - anuvratsingh:remove_in_band_lifetimes…
e670844 
…_compiler_rustc_traits, r=jackh726

Removed `in_band_lifetimes` from `rustc_traits`

Issue: [rust-lang#91867](rust-lang#91867)
bors added a commit to rust-lang/rust-clippy that referenced this issue Jan 12, 2022
@bors
Auto merge of #8190 - camsteffen:no-in-band-liftetimes, r=flip1995
ae01c4a 
Stop using `in_band_lifetimes`

Per rust-lang/rust#91867

changelog: none
@scottmcm
Copy link
Member Author

Looks like these have all landed, so I'll close this.

Thanks for the help, everyone!

@cuviper cuviper mentioned this issue Feb 18, 2022
Merged
@Veykril Veykril mentioned this issue Feb 22, 2022
Closed
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this issue Mar 2, 2022
@he32
rust: update to version 1.59.0.
d461c85 
Pkgsrc changes:
 * Bump available bootstraps to 1.58.1.
 * Adjust one patch (and checksum) so that it still applies.

Upstream changes:

Version 1.59.0 (2022-02-24)
==========================

Language
--------

- [Stabilize default arguments for const generics][90207]
- [Stabilize destructuring assignment][90521]
- [Relax private in public lint on generic bounds and where clauses
  of trait impls][90586]
- [Stabilize asm! and global_asm! for x86, x86_64, ARM, Aarch64,
  and RISC-V][91728]

Compiler
--------

- [Stabilize new symbol mangling format, leaving it opt-in
  (-Csymbol-mangling-version=v0)][90128]
- [Emit LLVM optimization remarks when enabled with `-Cremark`][90833]
- [Fix sparc64 ABI for aggregates with floating point members][91003]
- [Warn when a `#[test]`-like built-in attribute macro is present
  multiple times.][91172]
- [Add support for riscv64gc-unknown-freebsd][91284]
- [Stabilize `-Z emit-future-incompat` as `--json future-incompat`][91535]
- [Soft disable incremental compilation][94124]

This release disables incremental compilation, unless the user has explicitly
opted in via the newly added RUSTC_FORCE_INCREMENTAL=1 environment variable.
This is due to a known and relatively frequently occurring bug in incremental
compilation, which causes builds to issue internal compiler errors. This
particular bug is already fixed on nightly, but that fix has not yet rolled out
to stable and is deemed too risky for a direct stable backport.

As always, we encourage users to test with nightly and report bugs so that we
can track failures and fix issues earlier.

See [94124] for more details.

[94124]: rust-lang/rust#94124

Libraries
---------

- [Remove unnecessary bounds for some Hash{Map,Set} methods][91593]

Stabilized APIs
---------------

- [`std::thread::available_parallelism`][available_parallelism]
- [`Result::copied`][result-copied]
- [`Result::cloned`][result-cloned]
- [`arch::asm!`][asm]
- [`arch::global_asm!`][global_asm]
- [`ops::ControlFlow::is_break`][is_break]
- [`ops::ControlFlow::is_continue`][is_continue]
- [`TryFrom<char> for u8`][try_from_char_u8]
- [`char::TryFromCharError`][try_from_char_err]
  implementing `Clone`, `Debug`, `Display`, `PartialEq`, `Copy`, `Eq`, `Error`
- [`iter::zip`][zip]
- [`NonZeroU8::is_power_of_two`][is_power_of_two8]
- [`NonZeroU16::is_power_of_two`][is_power_of_two16]
- [`NonZeroU32::is_power_of_two`][is_power_of_two32]
- [`NonZeroU64::is_power_of_two`][is_power_of_two64]
- [`NonZeroU128::is_power_of_two`][is_power_of_two128]
- [`DoubleEndedIterator for ToLowercase`][lowercase]
- [`DoubleEndedIterator for ToUppercase`][uppercase]
- [`TryFrom<&mut [T]> for [T; N]`][tryfrom_ref_arr]
- [`UnwindSafe for Once`][unwindsafe_once]
- [`RefUnwindSafe for Once`][refunwindsafe_once]
- [armv8 neon intrinsics for aarch64][stdarch/1266]

Const-stable:

- [`mem::MaybeUninit::as_ptr`][muninit_ptr]
- [`mem::MaybeUninit::assume_init`][muninit_init]
- [`mem::MaybeUninit::assume_init_ref`][muninit_init_ref]
- [`ffi::CStr::from_bytes_with_nul_unchecked`][cstr_from_bytes]

Cargo
-----

- [Stabilize the `strip` profile option][cargo/10088]
- [Stabilize future-incompat-report][cargo/10165]
- [Support abbreviating `--release` as `-r`][cargo/10133]
- [Support `term.quiet` configuration][cargo/10152]
- [Remove `--host` from cargo {publish,search,login}][cargo/10145]

Compatibility Notes
-------------------

- [Refactor weak symbols in std::sys::unix][90846]
  This may add new, versioned, symbols when building with a newer glibc, as the
  standard library uses weak linkage rather than dynamically attempting to load
  certain symbols at runtime.
- [Deprecate crate_type and crate_name nested inside `#![cfg_attr]`][83744]
  This adds a future compatibility lint to supporting the use of cfg_attr
  wrapping either crate_type or crate_name specification within Rust files;
  it is recommended that users migrate to setting the equivalent command line
  flags.
- [Remove effect of `#[no_link]` attribute on name resolution][92034]
  This may expose new names, leading to conflicts with preexisting names in a
  given namespace and a compilation failure.
- [Cargo will document libraries before binaries.][cargo/10172]
- [Respect doc=false in dependencies, not just the root crate][cargo/10201]
- [Weaken guarantee around advancing underlying iterators in zip][83791]
- [Make split_inclusive() on an empty slice yield an empty output][89825]
- [Update std::env::temp_dir to use GetTempPath2 on Windows when
  available.][89999]
- [unreachable! was updated to match other formatting macro behavior
  on Rust 2021][92137]

Internal Changes
----------------

These changes provide no direct user facing benefits, but represent significant
improvements to the internals and overall performance of rustc
and related tools.

- [Fix many cases of normalization-related ICEs][91255]
- [Replace dominators algorithm with simple Lengauer-Tarjan][85013]
- [Store liveness in interval sets for region inference][90637]

- [Remove `in_band_lifetimes` from the compiler and standard library,
  in preparation for removing this unstable feature.][91867]

[91867]: rust-lang/rust#91867
[83744]: rust-lang/rust#83744
[83791]: rust-lang/rust#83791
[85013]: rust-lang/rust#85013
[89825]: rust-lang/rust#89825
[89999]: rust-lang/rust#89999
[90128]: rust-lang/rust#90128
[90207]: rust-lang/rust#90207
[90521]: rust-lang/rust#90521
[90586]: rust-lang/rust#90586
[90637]: rust-lang/rust#90637
[90833]: rust-lang/rust#90833
[90846]: rust-lang/rust#90846
[91003]: rust-lang/rust#91003
[91172]: rust-lang/rust#91172
[91255]: rust-lang/rust#91255
[91284]: rust-lang/rust#91284
[91535]: rust-lang/rust#91535
[91593]: rust-lang/rust#91593
[91728]: rust-lang/rust#91728
[91878]: rust-lang/rust#91878
[91896]: rust-lang/rust#91896
[91926]: rust-lang/rust#91926
[91984]: rust-lang/rust#91984
[92020]: rust-lang/rust#92020
[92034]: rust-lang/rust#92034
[92483]: rust-lang/rust#92483
[cargo/10088]: rust-lang/cargo#10088
[cargo/10133]: rust-lang/cargo#10133
[cargo/10145]: rust-lang/cargo#10145
[cargo/10152]: rust-lang/cargo#10152
[cargo/10165]: rust-lang/cargo#10165
[cargo/10172]: rust-lang/cargo#10172
[cargo/10201]: rust-lang/cargo#10201
[cargo/10269]: rust-lang/cargo#10269

[cstr_from_bytes]: https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html#method.from_bytes_with_nul_unchecked
[muninit_ptr]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.as_ptr
[muninit_init]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init
[muninit_init_ref]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_ref
[unwindsafe_once]: https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-UnwindSafe
[refunwindsafe_once]: https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-RefUnwindSafe
[tryfrom_ref_arr]: https://doc.rust-lang.org/stable/std/convert/trait.TryFrom.html#impl-TryFrom%3C%26%27_%20mut%20%5BT%5D%3E
[lowercase]: https://doc.rust-lang.org/stable/std/char/struct.ToLowercase.html#impl-DoubleEndedIterator
[uppercase]: https://doc.rust-lang.org/stable/std/char/struct.ToUppercase.html#impl-DoubleEndedIterator
[try_from_char_err]: https://doc.rust-lang.org/stable/std/char/struct.TryFromCharError.html
[available_parallelism]: https://doc.rust-lang.org/stable/std/thread/fn.available_parallelism.html
[result-copied]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.copied
[result-cloned]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.cloned
[asm]: https://doc.rust-lang.org/stable/core/arch/macro.asm.html
[global_asm]: https://doc.rust-lang.org/stable/core/arch/macro.global_asm.html
[is_break]: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html#method.is_break
[is_continue]: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html#method.is_continue
[try_from_char_u8]: https://doc.rust-lang.org/stable/std/primitive.char.html#impl-TryFrom%3Cchar%3E
[zip]: https://doc.rust-lang.org/stable/std/iter/fn.zip.html
[is_power_of_two8]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU8.html#method.is_power_of_two
[is_power_of_two16]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU16.html#method.is_power_of_two
[is_power_of_two32]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU32.html#method.is_power_of_two
[is_power_of_two64]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU64.html#method.is_power_of_two
[is_power_of_two128]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU128.html#method.is_power_of_two
[stdarch/1266]: rust-lang/stdarch#1266
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Apr 15, 2022
@he32
rust: update to version 1.59.0.
3818ff4 
Pkgsrc changes:
 * Bump available bootstraps to 1.58.1.
 * Adjust one patch (and checksum) so that it still applies.

Upstream changes:

Version 1.59.0 (2022-02-24)
==========================

Language
--------

- [Stabilize default arguments for const generics][90207]
- [Stabilize destructuring assignment][90521]
- [Relax private in public lint on generic bounds and where clauses
  of trait impls][90586]
- [Stabilize asm! and global_asm! for x86, x86_64, ARM, Aarch64,
  and RISC-V][91728]

Compiler
--------

- [Stabilize new symbol mangling format, leaving it opt-in
  (-Csymbol-mangling-version=v0)][90128]
- [Emit LLVM optimization remarks when enabled with `-Cremark`][90833]
- [Fix sparc64 ABI for aggregates with floating point members][91003]
- [Warn when a `#[test]`-like built-in attribute macro is present
  multiple times.][91172]
- [Add support for riscv64gc-unknown-freebsd][91284]
- [Stabilize `-Z emit-future-incompat` as `--json future-incompat`][91535]
- [Soft disable incremental compilation][94124]

This release disables incremental compilation, unless the user has explicitly
opted in via the newly added RUSTC_FORCE_INCREMENTAL=1 environment variable.
This is due to a known and relatively frequently occurring bug in incremental
compilation, which causes builds to issue internal compiler errors. This
particular bug is already fixed on nightly, but that fix has not yet rolled out
to stable and is deemed too risky for a direct stable backport.

As always, we encourage users to test with nightly and report bugs so that we
can track failures and fix issues earlier.

See [94124] for more details.

[94124]: rust-lang/rust#94124

Libraries
---------

- [Remove unnecessary bounds for some Hash{Map,Set} methods][91593]

Stabilized APIs
---------------

- [`std::thread::available_parallelism`][available_parallelism]
- [`Result::copied`][result-copied]
- [`Result::cloned`][result-cloned]
- [`arch::asm!`][asm]
- [`arch::global_asm!`][global_asm]
- [`ops::ControlFlow::is_break`][is_break]
- [`ops::ControlFlow::is_continue`][is_continue]
- [`TryFrom<char> for u8`][try_from_char_u8]
- [`char::TryFromCharError`][try_from_char_err]
  implementing `Clone`, `Debug`, `Display`, `PartialEq`, `Copy`, `Eq`, `Error`
- [`iter::zip`][zip]
- [`NonZeroU8::is_power_of_two`][is_power_of_two8]
- [`NonZeroU16::is_power_of_two`][is_power_of_two16]
- [`NonZeroU32::is_power_of_two`][is_power_of_two32]
- [`NonZeroU64::is_power_of_two`][is_power_of_two64]
- [`NonZeroU128::is_power_of_two`][is_power_of_two128]
- [`DoubleEndedIterator for ToLowercase`][lowercase]
- [`DoubleEndedIterator for ToUppercase`][uppercase]
- [`TryFrom<&mut [T]> for [T; N]`][tryfrom_ref_arr]
- [`UnwindSafe for Once`][unwindsafe_once]
- [`RefUnwindSafe for Once`][refunwindsafe_once]
- [armv8 neon intrinsics for aarch64][stdarch/1266]

Const-stable:

- [`mem::MaybeUninit::as_ptr`][muninit_ptr]
- [`mem::MaybeUninit::assume_init`][muninit_init]
- [`mem::MaybeUninit::assume_init_ref`][muninit_init_ref]
- [`ffi::CStr::from_bytes_with_nul_unchecked`][cstr_from_bytes]

Cargo
-----

- [Stabilize the `strip` profile option][cargo/10088]
- [Stabilize future-incompat-report][cargo/10165]
- [Support abbreviating `--release` as `-r`][cargo/10133]
- [Support `term.quiet` configuration][cargo/10152]
- [Remove `--host` from cargo {publish,search,login}][cargo/10145]

Compatibility Notes
-------------------

- [Refactor weak symbols in std::sys::unix][90846]
  This may add new, versioned, symbols when building with a newer glibc, as the
  standard library uses weak linkage rather than dynamically attempting to load
  certain symbols at runtime.
- [Deprecate crate_type and crate_name nested inside `#![cfg_attr]`][83744]
  This adds a future compatibility lint to supporting the use of cfg_attr
  wrapping either crate_type or crate_name specification within Rust files;
  it is recommended that users migrate to setting the equivalent command line
  flags.
- [Remove effect of `#[no_link]` attribute on name resolution][92034]
  This may expose new names, leading to conflicts with preexisting names in a
  given namespace and a compilation failure.
- [Cargo will document libraries before binaries.][cargo/10172]
- [Respect doc=false in dependencies, not just the root crate][cargo/10201]
- [Weaken guarantee around advancing underlying iterators in zip][83791]
- [Make split_inclusive() on an empty slice yield an empty output][89825]
- [Update std::env::temp_dir to use GetTempPath2 on Windows when
  available.][89999]
- [unreachable! was updated to match other formatting macro behavior
  on Rust 2021][92137]

Internal Changes
----------------

These changes provide no direct user facing benefits, but represent significant
improvements to the internals and overall performance of rustc
and related tools.

- [Fix many cases of normalization-related ICEs][91255]
- [Replace dominators algorithm with simple Lengauer-Tarjan][85013]
- [Store liveness in interval sets for region inference][90637]

- [Remove `in_band_lifetimes` from the compiler and standard library,
  in preparation for removing this unstable feature.][91867]

[91867]: rust-lang/rust#91867
[83744]: rust-lang/rust#83744
[83791]: rust-lang/rust#83791
[85013]: rust-lang/rust#85013
[89825]: rust-lang/rust#89825
[89999]: rust-lang/rust#89999
[90128]: rust-lang/rust#90128
[90207]: rust-lang/rust#90207
[90521]: rust-lang/rust#90521
[90586]: rust-lang/rust#90586
[90637]: rust-lang/rust#90637
[90833]: rust-lang/rust#90833
[90846]: rust-lang/rust#90846
[91003]: rust-lang/rust#91003
[91172]: rust-lang/rust#91172
[91255]: rust-lang/rust#91255
[91284]: rust-lang/rust#91284
[91535]: rust-lang/rust#91535
[91593]: rust-lang/rust#91593
[91728]: rust-lang/rust#91728
[91878]: rust-lang/rust#91878
[91896]: rust-lang/rust#91896
[91926]: rust-lang/rust#91926
[91984]: rust-lang/rust#91984
[92020]: rust-lang/rust#92020
[92034]: rust-lang/rust#92034
[92483]: rust-lang/rust#92483
[cargo/10088]: rust-lang/cargo#10088
[cargo/10133]: rust-lang/cargo#10133
[cargo/10145]: rust-lang/cargo#10145
[cargo/10152]: rust-lang/cargo#10152
[cargo/10165]: rust-lang/cargo#10165
[cargo/10172]: rust-lang/cargo#10172
[cargo/10201]: rust-lang/cargo#10201
[cargo/10269]: rust-lang/cargo#10269

[cstr_from_bytes]: https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html#method.from_bytes_with_nul_unchecked
[muninit_ptr]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.as_ptr
[muninit_init]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init
[muninit_init_ref]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_ref
[unwindsafe_once]: https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-UnwindSafe
[refunwindsafe_once]: https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-RefUnwindSafe
[tryfrom_ref_arr]: https://doc.rust-lang.org/stable/std/convert/trait.TryFrom.html#impl-TryFrom%3C%26%27_%20mut%20%5BT%5D%3E
[lowercase]: https://doc.rust-lang.org/stable/std/char/struct.ToLowercase.html#impl-DoubleEndedIterator
[uppercase]: https://doc.rust-lang.org/stable/std/char/struct.ToUppercase.html#impl-DoubleEndedIterator
[try_from_char_err]: https://doc.rust-lang.org/stable/std/char/struct.TryFromCharError.html
[available_parallelism]: https://doc.rust-lang.org/stable/std/thread/fn.available_parallelism.html
[result-copied]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.copied
[result-cloned]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.cloned
[asm]: https://doc.rust-lang.org/stable/core/arch/macro.asm.html
[global_asm]: https://doc.rust-lang.org/stable/core/arch/macro.global_asm.html
[is_break]: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html#method.is_break
[is_continue]: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html#method.is_continue
[try_from_char_u8]: https://doc.rust-lang.org/stable/std/primitive.char.html#impl-TryFrom%3Cchar%3E
[zip]: https://doc.rust-lang.org/stable/std/iter/fn.zip.html
[is_power_of_two8]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU8.html#method.is_power_of_two
[is_power_of_two16]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU16.html#method.is_power_of_two
[is_power_of_two32]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU32.html#method.is_power_of_two
[is_power_of_two64]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU64.html#method.is_power_of_two
[is_power_of_two128]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU128.html#method.is_power_of_two
[stdarch/1266]: rust-lang/stdarch#1266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@pitaj @bugadani @Aaron1011 @LegionMammal978 @SylvanB @scottmcm @camelid @Patrick-Poitras @lameferret