Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile TAIT tests #86727

Closed
nikomatsakis opened this issue Jun 29, 2021 · 2 comments
Closed

Reconcile TAIT tests #86727

nikomatsakis opened this issue Jun 29, 2021 · 2 comments
Assignees
@spastorino
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

The draft stabilization report for "min TAIT" includes a series of test scenarios:

We need to go through the existing tests and either give examples of each scenario or add new ones. You can just edit the draft stabilization report hackmd directly.
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` labels Jun 29, 2021
@jackh726 jackh726 added the E-help-wanted Call for participation: Help is requested to fix this issue. label Jun 29, 2021
@spastorino spastorino self-assigned this Jun 29, 2021
@jackh726 jackh726 added F-min_type_alias_impl_trait and removed F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` labels Jun 29, 2021
This was referenced Aug 20, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
jackh726 added a commit to jackh726/rust that referenced this issue Aug 22, 2021
@jackh726
Rollup merge of rust-lang#88172 - spastorino:tait-defining-use-submod…
0689152 
…ule-test, r=oli-obk

Test that type alias impl trait happens in a submodule

r? `@oli-obk`

Related to rust-lang#86727
jackh726 added a commit to jackh726/rust that referenced this issue Aug 22, 2021
@jackh726
Rollup merge of rust-lang#88182 - spastorino:use-trait-in-tait-tests,…
5be51f2 
… r=oli-obk

We meant to use a trait instead of lifetime here

r? `@oli-obk`

Related to rust-lang#86727
jackh726 added a commit to jackh726/rust that referenced this issue Aug 22, 2021
@jackh726
Rollup merge of rust-lang#88183 - spastorino:add-tait-in-different-tu…
ae58c51 
…ple-position, r=oli-obk

test TAIT in different positions

r? `@oli-obk`

Related to rust-lang#86727
jackh726 added a commit to jackh726/rust that referenced this issue Aug 22, 2021
@jackh726
Rollup merge of rust-lang#88189 - spastorino:add-tait-struct-test, r=…
73d9758 
…oli-obk

Add TAIT struct test

r? `@oli-obk`

Related to rust-lang#86727
jackh726 added a commit to jackh726/rust that referenced this issue Aug 22, 2021
@jackh726
Rollup merge of rust-lang#88192 - spastorino:add-tait-test-for-assoc-…
d6492b1 
…dyn, r=oli-obk

Use of impl trait in an impl as the value for an associated type in a dyn

r? `@oli-obk`

Related to rust-lang#86727
jackh726 added a commit to jackh726/rust that referenced this issue Aug 22, 2021
@jackh726
Rollup merge of rust-lang#88194 - spastorino:test-tait-assoc-impl-tra…
66b04c6 
…it, r=oli-obk

Test use of impl Trait in an impl as the value for an associated type in an impl trait

r? `@oli-obk`

Related to rust-lang#86727
jackh726 added a commit to jackh726/rust that referenced this issue Aug 22, 2021
@jackh726
Rollup merge of rust-lang#88197 - spastorino:tait-test-fn-type, r=oli…
1d0d7c3 
…-obk

Test tait use in a fn type

r? `@oli-obk`

I thought this was going to work but doesn't, quickly checked with Niko and he told me that we ruled this out for now. I'm not exactly sure why and how but here we have a test with a FIXME :)

Related to rust-lang#86727
jackh726 added a commit to jackh726/rust that referenced this issue Aug 22, 2021
@jackh726
Rollup merge of rust-lang#88201 - spastorino:tait-incomplete-inferenc…
b9b53c8 
…e-test, r=oli-obk

Test that incomplete inference for TAITs fail

r? `@oli-obk`

Related to rust-lang#86727
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 23, 2021
@bors
Auto merge of rust-lang#88210 - spastorino:diff-lifetimes-def-use-tes…
4996735 
…t, r=oli-obk

Test TAITs different lifetimes in defining uses fail

r? `@oli-obk`

Related to rust-lang#86727
@spastorino spastorino mentioned this issue Aug 25, 2021
Merged
LeSeulArtichaut added a commit to LeSeulArtichaut/rust that referenced this issue Aug 25, 2021
@LeSeulArtichaut
Rollup merge of rust-lang#88314 - spastorino:type-of-a-let-tait-test,…
16fd95c 
… r=oli-obk

Add type of a let tait test

r? `@oli-obk`

Related to rust-lang#86727
This was referenced Aug 25, 2021
Merged
Merged
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Aug 26, 2021
@Dylan-DPC
Rollup merge of rust-lang#88348 - spastorino:field-types-tait-test, r…
a25041f 
…=oli-obk

Add field types tait tests

r? `@oli-obk`

Related to rust-lang#86727
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Aug 26, 2021
@Dylan-DPC
Rollup merge of rust-lang#88349 - spastorino:const-static-types-tait-…
a4dd3f4 
…test, r=oli-obk

Add const and static TAIT tests

r? `@oli-obk`

Related to rust-lang#86727
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 26, 2021
@GuillaumeGomez
Rollup merge of rust-lang#88348 - spastorino:field-types-tait-test, r…
84e8622 
…=oli-obk

Add field types tait tests

r? ``@oli-obk``

Related to rust-lang#86727
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 26, 2021
@GuillaumeGomez
Rollup merge of rust-lang#88349 - spastorino:const-static-types-tait-…
e302595 
…test, r=oli-obk

Add const and static TAIT tests

r? ``@oli-obk``

Related to rust-lang#86727
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Aug 26, 2021
@Dylan-DPC
Rollup merge of rust-lang#88332 - spastorino:argument-types-tait-test…
41fbafa 
…, r=oli-obk

Add argument types tait tests

r? `@oli-obk`

Related to rust-lang#86727
Manishearth added a commit to Manishearth/rust that referenced this issue Aug 26, 2021
@Manishearth
Rollup merge of rust-lang#88332 - spastorino:argument-types-tait-test…
0f7dc5d 
…, r=oli-obk

Add argument types tait tests

r? ``@oli-obk``

Related to rust-lang#86727
Manishearth added a commit to Manishearth/rust that referenced this issue Aug 26, 2021
@Manishearth
Rollup merge of rust-lang#88348 - spastorino:field-types-tait-test, r…
af54936 
…=oli-obk

Add field types tait tests

r? ```@oli-obk```

Related to rust-lang#86727
Manishearth added a commit to Manishearth/rust that referenced this issue Aug 27, 2021
@Manishearth
Rollup merge of rust-lang#88349 - spastorino:const-static-types-tait-…
e5c1e70 
…test, r=oli-obk

Add const and static TAIT tests

r? ```@oli-obk```

Related to rust-lang#86727
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Aug 27, 2021
@Dylan-DPC
Rollup merge of rust-lang#88349 - spastorino:const-static-types-tait-…
191ca73 
…test, r=oli-obk

Add const and static TAIT tests

r? ````@oli-obk````

Related to rust-lang#86727
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Aug 27, 2021
@Dylan-DPC
Rollup merge of rust-lang#88349 - spastorino:const-static-types-tait-…
45f5b4e 
…test, r=oli-obk

Add const and static TAIT tests

r? `````@oli-obk`````

Related to rust-lang#86727
This was referenced Aug 27, 2021
Merged
Merged
Merged
Merged
@spastorino
Copy link
Member

I think this issue can be closed now. I've built a table here https://hackmd.io/y1HwFSBUQS2ZKrSFuQ0Dnw?view with existing tests, some desired ones and ended creating new tests for the desired ones that were missing. The table reflects that showing PRs for cases that were uncovered.

Please whoever that is reading this and have time and energy :), please check it out and let me know if there's something missing or feel free to add more tests :).

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 29, 2021
@GuillaumeGomez
Rollup merge of rust-lang#88349 - spastorino:const-static-types-tait-…
3e1a15b 
…test, r=oli-obk

Add const and static TAIT tests

r? ``@oli-obk``

Related to rust-lang#86727
m-ou-se added a commit to m-ou-se/rust that referenced this issue Aug 31, 2021
@m-ou-se
Rollup merge of rust-lang#88406 - spastorino:tait-nest-infer-test, r=…
5eeeb0b 
…oli-obk

Tait nest infer test

r? `@oli-obk`

Related to rust-lang#86727
m-ou-se added a commit to m-ou-se/rust that referenced this issue Aug 31, 2021
@m-ou-se
Rollup merge of rust-lang#88408 - spastorino:inference-cycle-tait-tes…
b490f35 
…t, r=oli-obk

Add inference cycle TAIT test

r? `@oli-obk`

Related to rust-lang#86727
m-ou-se added a commit to m-ou-se/rust that referenced this issue Aug 31, 2021
@m-ou-se
Rollup merge of rust-lang#88409 - spastorino:autoleakage-tait-test, r…
0e49feb 
…=oli-obk

Add auto trait leakage TAIT test

r? `@oli-obk`

Related to rust-lang#86727
m-ou-se added a commit to m-ou-se/rust that referenced this issue Aug 31, 2021
@m-ou-se
Rollup merge of rust-lang#88413 - spastorino:weird-return-types-tait-…
2013792 
…test, r=oli-obk

Add weird return types TAIT test

r? `@oli-obk`

Related to rust-lang#86727
@spastorino
Copy link
Member

spastorino commented Aug 31, 2021 •
edited
Loading

All the open PRs about this are now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spastorino spastorino

Labels
E-help-wanted Call for participation: Help is requested to fix this issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spastorino @nikomatsakis @jackh726