redundant_locals: fix FPs on mutated shadows #11320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
When a mutable binding is shadowed by a mutable binding of the same name in a different scope, mutations in that scope have different meaning. This commit fixes spurious `redundant_locals` emissions on such locals.
max-niederman
force-pushed
the
redundant_locals_shadow_mutated
branch
from
9ec1af8
to
a5f62bd
Compare
Alexendoo
approved these changes
Aug 11, 2023
|
Thanks! @bors r+ |
Alexendoo
added
the
beta-nominated
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
flip1995
removed
the
beta-nominated
|
No backport necessary: This fix already is synced and this lint isn't included in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11290.
When a mutable binding is shadowed by
a mutable binding of the same name in a different scope, mutations in that scope have different meaning.
This PR fixes spurious
redundant_localsemissions on such locals.cc @Centri3, @flip1995
changelog: [
redundant_locals]: fix false positives on mutated shadows