This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Fix hover infinite loop #1170
Merged
Fix hover infinite loop #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extract_docs continue clause could cause endless looping if moving up & top line meta
|
@nrc it'd be nice to backport this fix to stable too I think. |
|
\o/ Thanks! If we do a point release for stable I'll include this, but I don't think we can do a point release just for this |
|
How do I rustup the fix into nightly?
|
|
@vi the rust-lang/rust rls submodule will have to be updated to bfa1371 or later with a pull request. After merging rls will be fixed the following nightly release. In general it takes a few days to a week for a fix in rls to filter through to the nightly release. |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Dec 18, 2018
[stable] 1.31.1 point release Rust 1.31.1 is scheduled to be released on Thursday 20th, with the following changes: * #56562: Update libc version required by rustc *(different patch made by me)* * #56615: Update the book to fix some edition-related bugs * rls submodule update to [`b379ef7`](rust-lang/rls@b379ef7), including: * rust-lang/rls#1170: Fix for common infinte loop regression * rust-lang/rls#1171: Can't jump to std defs r? @Mark-Simulacrum cc @rust-lang/core @rust-lang/release
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 22, 2018
Pkgsrc changes: * Sadly, I had to reinstate the "make tar files" rust code to make it possible to build cross-compiled bootstrap kits. * Add an adjustable "BUILD_TARGET", "dist" for cross-building a bootstrap kit, "build" for a normal native build. * New bootstrap kits built for NetBSD/powerpc, NetBSD/earmv7hf, and NetBSD/sparc64 version 1.31.1. * gcc-wrap script amended to also drop -Wl,--enable-new-dtags (so it could be used outside pkgsrc) * Worked around use of AtomicU64 in release build tool (ugly band-aid patch). Some platforms lack support for that type and associated operations. Upstream changes: - [Fix Rust failing to build on `powerpc-unknown-netbsd`][56562] - [Fix broken go-to-definition in RLS][rls/1171] - [Fix infinite loop on hover in RLS][rls/1170] [56562]: rust-lang/rust#56562 [rls/1171]: rust-lang/rls#1171 [rls/1170]: rust-lang/rls#1170
Xanewok
added a commit
to Xanewok/rust
that referenced
this pull request
Jan 3, 2019
Beta backport of a fix that already was backported to stable, see rust-lang#56726 and rust-lang/rls#1170 for the underlying RLS issue. Also includes the fix for rust-lang/rls#1154 (respecting target-dir specified in .cargo/config for RLS artifacts).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract_docsif-continue could cause endless looping if moving up & top line meta.after fix:
Fixes #1168