Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some SSE/SSE2 intrinsics that are no longer used by stdarch #3747

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove some SSE/SSE2 intrinsics that are no longer used by stdarch #3747

wants to merge 1 commit into from

Conversation

RalfJung
Copy link
Member

Fixes #3691

@RalfJung
Copy link
Member Author

Blocked on rust-lang/stdarch#1584 propagating to the rustc repo.

@RalfJung RalfJung added the S-blocked Status: blocked on something happening somewhere else label Jul 13, 2024
@TDecking
Copy link
Contributor

The stdarch patch will also ensure that the "sqrt.ps.256" case in https://github.com/rust-lang/miri/blob/master/src/shims/x86/avx.rs#L78 will never be reached. This case is still present here.

@RalfJung
Copy link
Member Author

Yeah, but sqrt is implemented together with two other functions there so there's not really any code saved by removing that... 🤷

The same goes for sse.sqrt.ss, sse.sqrt.ps.

@RalfJung
Copy link
Member Author

Hm I guess this removes all uses of FloatUnaryOp::Sqrt. So maybe it's worth it after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-blocked Status: blocked on something happening somewhere else
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dead Intel intrinsics
2 participants
@RalfJung @TDecking