add the pext and pdep intrinsics
#3676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
commented
Jun 15, 2024
| match unprefixed_name { | ||
| "pdep.32" => { | ||
| // <https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_pdep_u32> | ||
| this.expect_target_feature_for_intrinsic(link_name, "bmi2")?; |
There was a problem hiding this comment.
llvm unhelpfully does not make a distinction between bmi1 and bmi2: all bmi intrinsics are in the bmi namespace. So I don't see another way than to in every branch check for the relevant target features, even though it is error-prone.
|
whoops, #3674 exists |
|
Ah, that is an unfortunate coincidence that you both wrote the same PR at the same time...
If you could take a look at the other PR, some help with reviewing is always appreciated. :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for parallel bit extraction and deposition.
These are useful in low-level parsing code.
Wikipedia has an explanation of what these do.