add an option to track raw pointer tags in Stacked Borrows #1603
Conversation
| * `-Zmiri-track-call-id=<id>` shows a backtrace when the given call id is | ||
| assigned to a stack frame. This helps in debugging UB related to Stacked | ||
| Borrows "protectors". | ||
| * `-Zmiri-track-raw-pointers` makes Stacked Borrows track a pointer tag even for |
There was a problem hiding this comment.
can you construct a test for both the false positive case as well as an example where we now detect latent aliasing where we didn't before? (I'm guessing under certain circumstances they could be one and the same test? we'd just detect the aliasing earlier now)
There was a problem hiding this comment.
An example with a false positive caused by this flag is run-pass/box.rs, since it casts a ptr to an int and back.
I can add a test for a bug that would otherwise be missed (rust-lang/rust#78477 is the example that motivated this change).
|
Argh, this fails on Windows because there are integer-pointer casts in the runtime there... is there a way with compiletest to pass a compile-flag only on linux? Otherwise we might just have to disable these tests on Windows (they do not test anything platform-specific so that seems okay). |
no, all you can do is use |
|
I doubt the old compiletest in the stand-alone crate supports revisions... |
|
@bors r+ |
|
📌 Commit bf54607 has been approved by |
|
☀️ Test successful - checks-actions |
Also make error messages more informative by printing the affected memory location