Fix issue with field retagging in scopeguard #359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With field retagging in SB, this causes UB because the read out value is invalidated by the move into
mem::forget
. UsingManuallyDrop<T>
avoids the problem. With that issue fixed, we can now enable field retagging in CI. Field retagging is required to justify some of thenoalias
optimizations that rustcperforms currently.
Miri error