Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grss implementation to errors chapter #233

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

stomar
Copy link
Contributor

@stomar stomar commented Nov 5, 2023

At the end of the chapter, provide a running code example that applies the nicer error reporting to the grrs tool.

At the end of the chapter, provide a running code example
that applies the nicer error reporting to the `grrs` tool.
@stomar
Copy link
Contributor Author

stomar commented Nov 5, 2023

I think the chapters following 1.3 should continue to improve the central grrs example step by step. This PR is a step in this direction.

See also #222.

Copy link
Contributor

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

src/tutorial/errors.md Outdated Show resolved Hide resolved
@stomar
Copy link
Contributor Author

stomar commented Nov 8, 2023

I do not know how PRs are usually merged in this repository (squash, rebase, etc.); in this case I would prefer both commits were kept separately, i. e. no "squash and merge". IMO the second commit does not improve the text, as explained above; I also do not see any value in using an (empty) phrase merely for "consistency" with only 2 other uses.

Thanks.

@pksunkara pksunkara merged commit 6fb70c9 into rust-cli:master Nov 10, 2023
4 checks passed
@stomar stomar deleted the add-grrs-impl-to-errors branch November 10, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants