This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
hex: Simplify and DRY-ify HexIterator #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenroose
reviewed
May 21, 2019
| /// Constructs a new `HexIterator` from a string slice. If the string is of odd length it | ||
| /// returns an error. | ||
| /// Constructs a new `HexIterator` from a string slice. If the string is of | ||
| /// odd length it returns an error. |
There was a problem hiding this comment.
Nice! Someone else who likes comments to be within 80 columns! Do you do this manually or do you have a Vim plugin that allows different textwidths for code vs comments?
There was a problem hiding this comment.
Haha I use emacs and Meta-q seems to just auto-align the current comment block you're in 😁
stevenroose
approved these changes
May 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old logic can be much simpler if we make the
HexIteratorwrap aChariterator instead.