fix: Recipes had drifted from the implementation and weren't compiling #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This 1. Adds the recipes to the doctests so that they don't drift anymore 2. Fixes them
Fyko
reviewed
Oct 20, 2023
| @@ -99,7 +101,7 @@ pub fn pinline_comment<'a, E: ParseError<&'a str>>(i: &'a str) -> IResult<&'a st | |||
| take_until("*)"), | |||
| tag("*)") | |||
| ) | |||
| )(i) | |||
| ).parse(i) | |||
There was a problem hiding this comment.
Why use parse on all these instead of parser functions?
There was a problem hiding this comment.
I think it is required since #1631 has been merged.
There was a problem hiding this comment.
nom is moving towards using traits instead of function as the main parser interface. You can still use functions though if you prefer
Geal
reviewed
Oct 21, 2023
src/lib.rs
Outdated
| @@ -466,3 +466,7 @@ pub mod number; | |||
| #[cfg(feature = "docsrs")] | |||
| #[cfg_attr(feature = "docsrs", cfg_attr(feature = "docsrs", doc = include_str!("../doc/nom_recipes.md")))] | |||
| pub mod recipes {} | |||
|
|
|||
| #[cfg(doctest)] | |||
There was a problem hiding this comment.
why not add doctest to the definition above?
Geal
approved these changes
Oct 21, 2023
|
it took a bit of fiddling, but now all tests are passing in CI. Thankyou for your help! |
|
Perfect, I hadn't added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This