Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing combinators to choosing combinator guide #1665

Conversation

smheidrich
Copy link
Contributor

@smheidrich smheidrich commented May 10, 2023

Solves part of #1664

Adds:

  • value
  • many0_count
  • many1_count
  • take_while_m_n
  • all_consuming
  • cut
  • into
  • rest_len

Doesn't add:

  • fill because I don't know a good way to write an example in the format of that table for this one...
  • satisfy because it doesn't work with the u8 predicates like is_alphabetic etc. which makes it awkward to write an example
  • iterator (not really a combinator as it doesn't return a parser)
  • recognize_float and recognize_float_parts (don't see the point of those)

Someone who understands more about them could pick these up.

@smheidrich smheidrich changed the title Add missing combinators to choosing combinator guide Add some missing combinators to choosing combinator guide May 10, 2023
@smheidrich smheidrich force-pushed the add-missing-combinators-to-choosing-combinator-guide branch 3 times, most recently from c5a2a6e to 17d94eb Compare May 10, 2023 18:44
@smheidrich smheidrich marked this pull request as ready for review May 10, 2023 18:45
@smheidrich smheidrich requested a review from Geal as a code owner May 10, 2023 18:45
@smheidrich smheidrich force-pushed the add-missing-combinators-to-choosing-combinator-guide branch from 17d94eb to ad5e0b4 Compare May 11, 2023 16:57
@Geal Geal merged commit 4d46095 into rust-bakery:main Jun 10, 2023
@Geal
Copy link
Collaborator

Geal commented Jun 10, 2023

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants