Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multibyte char support in take_while_m_n #1651

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Fix multibyte char support in take_while_m_n #1651

merged 6 commits into from
Mar 15, 2023

Conversation

Geal
Copy link
Collaborator

@Geal Geal commented Mar 14, 2023

Fix #1630
Replaces #1643

@coveralls
Copy link

coveralls commented Mar 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4420539705

  • 29 of 32 (90.63%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 62.445%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bytes/complete.rs 13 16 81.25%
Totals Coverage Status
Change from base Build 4420062193: 0.9%
Covered Lines: 1558
Relevant Lines: 2495
💛 - Coveralls

@Geal Geal merged commit c83a3fd into main Mar 15, 2023
@Geal Geal deleted the fix-multibyte-take_while_m_n branch March 15, 2023 20:51
@Geal Geal mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

take_while_m_n is invalid for multi-byte UTF-8 characters
3 participants
@Geal @coveralls @ackxolotl