Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend the JSON benchmark #1639

Merged
merged 2 commits into from
Feb 13, 2023
Merged

extend the JSON benchmark #1639

merged 2 commits into from
Feb 13, 2023

Conversation

Geal
Copy link
Collaborator

@Geal Geal commented Feb 13, 2023

this adds a benchmark using a larger file, and compares the results with two different error types

this adds a benchmark using a larger file, and compares the results with
two ifferent error types
@coveralls
Copy link

coveralls commented Feb 13, 2023

Pull Request Test Coverage Report for Build 4167753547

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 61.912%

Changes Missing Coverage Covered Lines Changed/Added Lines %
benchmarks/benches/json.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/character/complete.rs 1 81.12%
src/character/streaming.rs 1 78.38%
benchmarks/benches/json.rs 8 0%
Totals Coverage Status
Change from base Build 3981619336: -0.3%
Covered Lines: 1554
Relevant Lines: 2510

💛 - Coveralls

@Geal Geal marked this pull request as ready for review February 13, 2023 21:05
@Geal Geal merged commit ec4a968 into main Feb 13, 2023
@Geal Geal deleted the json-bench branch February 13, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants