Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow conversion of Error and VerboseError to owned versions #1638

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Conversation

Geal
Copy link
Collaborator

@Geal Geal commented Feb 13, 2023

Error and VerboseError return references to input data, both for speed when traversing the parser, but also to allow post processing base on offsets into the input data. in some cases though, we would like to quicky convert them to owned versions to return them as part of larger error types

Error and VerboseError return references to input data, both for speed
when traversing the parser, but also to allow post processing base on
offsets into the input data. in some cases though, we would like to
quicky convert them to owned versions to return them as part of larger
error types
@coveralls
Copy link

coveralls commented Feb 13, 2023

Pull Request Test Coverage Report for Build 4167392130

  • 0 of 12 (0.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 61.878%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/error.rs 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
src/character/complete.rs 1 81.12%
src/error.rs 8 16.6%
Totals Coverage Status
Change from base Build 3981619336: -0.3%
Covered Lines: 1555
Relevant Lines: 2513

💛 - Coveralls

@Geal Geal marked this pull request as ready for review February 22, 2023 22:14
@Geal Geal merged commit 87d8555 into main Feb 22, 2023
@Geal Geal deleted the owned-errors branch February 22, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants