Fix clippy lints #299
Merged
Fix clippy lints #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace MetricsError::NonExhaustive with #[non_exhaustive] - Remove some redundant let bindings - Disconnect rayon::scope from result handling
|
Errors in ffmpeg crate build. I'll take a look... |
Closed
|
I think this one is fine to merge as-is... The FFmpeg build error will need to be fixed either by pinning FFmpeg to 5.X or by updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, this is technically a breaking change because
MetricsError::NonExhaustiveis technically part of the public API. But given that it isdoc(hidden)and explicitly not supposed to be used, I think this change is fine?I also updated one crate, which should hopefully be uncontroversial (proc-macro2)