feat: show video call for push notification #30
Conversation
add CallNotificationTypeManager add CallNotificationType setting UI refactor AccountTableViewController
unregister webhooks when changing call notification type.
save apns device token with the key "apnsDeviceToken"
|
|
||
| func endCurrentCall() { | ||
| if CallNotificationTypeManager.shared.getCurrentCallNotificationType() == .videoCall { | ||
| endCurrentCallKitCall() |
There was a problem hiding this comment.
maybe we can call this in the SDK's callback function "callEnded"? So based on usingCallKit we could decide to hide uikit or not?
There was a problem hiding this comment.
callEnded happens after endCurrentCall()
There was a problem hiding this comment.
oh, ok, so you end call kit call and it's delegate will call BMXCallKit.shared.endCall(), right?
| @@ -185,5 +233,57 @@ extension CallsService: PKPushRegistryDelegate, CXProviderDelegate { | |||
| func provider(_ provider: CXProvider, didDeactivate audioSession: AVAudioSession) { | |||
| BMXCallKit.shared.disconnectSoundDevice() | |||
| } | |||
|
|
|||
| func rejectCallForPushNotification(userInfo: [AnyHashable: Any]) { | |||
There was a problem hiding this comment.
when do you call it?
There was a problem hiding this comment.
Currently when app is in the foreground, the video call will begin automatically if an initial call push notification comes. I wanted to add some simple UI to give users a selection to accept or reject the call, so I added this function. Later I thought it was just a demo app, maybe I don't need to provide this selection. So I didn't add the selection but forgot deleting the function.
What do yo think about it?
Do you think we should provide a selection for users in this scenario?
There was a problem hiding this comment.
I think we can have a reject button, but would you need to call BMXCallKit.shared.processCall to reject it?
There was a problem hiding this comment.
Yes, I need to get a correct incomingCallProcessor because BMXCallKit.shared.endCall calls processor?.endCall(guid: callId)
There was a problem hiding this comment.
hm, that is not obvious and I think can confuse a SDK user, maybe process call should be inside BMXCallKit.shared.endCall then?
There was a problem hiding this comment.
Good suggestion. I will make changes inside BMXCallKit.shared.endCall then.
There was a problem hiding this comment.
@sviatoslavbmx I talked with Yurii and ended up adding a preview call UI for push notification with answer button and reject button, but I don't need rejectCallForPushNotification any more because I will directly use CallsService.shared.endCurrentCall()
rename video to voip for CallNotificationType
remove rejectCallForPushNotification
yingtao-butterflymx
requested review from
4taras4 and
sviatoslavbmx
and removed request for
sbelmeha
No description provided.