feat: incorporate Monarch support in the iOS Demo app #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make IncomingCallViewController conform to BMXCall.IncomingCallUIInputs call new API BMXCallKit.shared.processCall(guid:callType:incomingCallPresenter:completion) to process incoming calls.
sbelmeha
reviewed
Oct 11, 2021
| } | ||
|
|
||
| func handleCallConnected() { | ||
| DispatchQueue.main.async { |
There was a problem hiding this comment.
I think we need to call these function from the main queue by default from the SDK
There was a problem hiding this comment.
I fixed it.
use DispatchQueue.main.async in our SDK instead to make users easier to use the SDK.
sbelmeha
approved these changes
Oct 12, 2021
pass unwrapped incomingViewController (with guard let) to processCall
sbelmeha
approved these changes
Oct 14, 2021
yingtao-butterflymx
added a commit
that referenced
this pull request
Nov 17, 2021
* feat: incorporate Monarch support in the iOS Demo app (#24) * feat: use WebRTC supported SDK to open door make IncomingCallViewController conform to BMXCall.IncomingCallUIInputs call new API BMXCallKit.shared.processCall(guid:callType:incomingCallPresenter:completion) to process incoming calls. * refactor: remove some DispatchQueue.main.async use DispatchQueue.main.async in our SDK instead to make users easier to use the SDK. * refactor: remove extension for BMXCallDelegate * refactor: pass unwrapped incomingViewController pass unwrapped incomingViewController (with guard let) to processCall Refs # NT-458 * refactor: refactor code to handle more call scenarios (#25) * feat: use WebRTC supported SDK to open door make IncomingCallViewController conform to BMXCall.IncomingCallUIInputs call new API BMXCallKit.shared.processCall(guid:callType:incomingCallPresenter:completion) to process incoming calls. * refactor: remove some DispatchQueue.main.async use DispatchQueue.main.async in our SDK instead to make users easier to use the SDK. * refactor: remove extension for BMXCallDelegate * refactor: pass unwrapped incomingViewController pass unwrapped incomingViewController (with guard let) to processCall * refactor: add IncomingCallPresenter only reportNewIncomingCall for the intial call. show IncomingCallViewContrller after users press the accept button * fix: review fixes call CallsService.shared.endCurrentCallKitCall() instead of BMXCallKit.shared.endCall() in hangUpAction remove function handleCallEnded * refactor: use CallStatusHandler to handel handle call status changes * fix: review fixes remove CallEndReason * fix: review fixes use callConnected instead of handleCallConnected use callAccepted instead of handleCallAccepted Refs # NT-458 * fix: simplify Podfile * feat: mark Intercom and Keypads for devices (#26) add subtitle for DoorTableViewCell to show the current device is Intercom or KeyPad add setup(by device: DeviceModel) in DoorTableViewCell * chore: import BMXCore 2.1.0 and BMXCall 2.1.0
yingtao-butterflymx
added a commit
that referenced
this pull request
Nov 17, 2021
* feat: incorporate Monarch support in the iOS Demo app (#24) * feat: use WebRTC supported SDK to open door make IncomingCallViewController conform to BMXCall.IncomingCallUIInputs call new API BMXCallKit.shared.processCall(guid:callType:incomingCallPresenter:completion) to process incoming calls. * refactor: remove some DispatchQueue.main.async use DispatchQueue.main.async in our SDK instead to make users easier to use the SDK. * refactor: remove extension for BMXCallDelegate * refactor: pass unwrapped incomingViewController pass unwrapped incomingViewController (with guard let) to processCall Refs # NT-458 * refactor: refactor code to handle more call scenarios (#25) * feat: use WebRTC supported SDK to open door make IncomingCallViewController conform to BMXCall.IncomingCallUIInputs call new API BMXCallKit.shared.processCall(guid:callType:incomingCallPresenter:completion) to process incoming calls. * refactor: remove some DispatchQueue.main.async use DispatchQueue.main.async in our SDK instead to make users easier to use the SDK. * refactor: remove extension for BMXCallDelegate * refactor: pass unwrapped incomingViewController pass unwrapped incomingViewController (with guard let) to processCall * refactor: add IncomingCallPresenter only reportNewIncomingCall for the intial call. show IncomingCallViewContrller after users press the accept button * fix: review fixes call CallsService.shared.endCurrentCallKitCall() instead of BMXCallKit.shared.endCall() in hangUpAction remove function handleCallEnded * refactor: use CallStatusHandler to handel handle call status changes * fix: review fixes remove CallEndReason * fix: review fixes use callConnected instead of handleCallConnected use callAccepted instead of handleCallAccepted Refs # NT-458 * fix: simplify Podfile * feat: mark Intercom and Keypads for devices (#26) add subtitle for DoorTableViewCell to show the current device is Intercom or KeyPad add setup(by device: DeviceModel) in DoorTableViewCell * chore: import BMXCore 2.1.0 and BMXCall 2.1.0 * chore: import BMXCall 2.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make IncomingCallViewController conform to BMXCall.IncomingCallUIInputs
call new API BMXCallKit.shared.processCall(guid:callType:incomingCallPresenter:completion) to process incoming calls.