Fix project, minor parsing bug. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears project is slightly too permissive in the same way that extend was. `project id b` is invalid, same as `project id=1 b`. Ensure we are requiring a comma or EOF at the end of each project statement.
|
@abraithwaite i added a test, are you happy with this? If so I'll add the same for the extend |
|
@abraithwaite i added a test, are you happy with this? If so I'll add the same for the extend |
|
Accidently pressed close instead of comment. @abraithwaite are you happy with this? If so Ill add the same for extend. I added your test |
abraithwaite
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears project is slightly too permissive in the same way that extend was.
project id bis invalid, same asproject id=1 b.Ensure we are requiring a comma or EOF at the end of each project statement.