Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bundle fails to be created on Windows #897

Open
pendo324 opened this issue Apr 12, 2024 · 0 comments
Open

Support bundle fails to be created on Windows #897

pendo324 opened this issue Apr 12, 2024 · 0 comments
Assignees
@haytok
Labels
bug Something isn't working

Comments

@pendo324
Copy link
Member

Describe the bug
On Windows, running finch support-bundle generate fails with the following error:

level=fatal msg="exec: \"uname\": executable file not found in %PATH%"

Steps to reproduce
Run finch support-bundle generate on Windows.

Expected behavior
A support bundle should be created.

Screenshots or logs
If applicable, add screenshots or logs to help explain your problem.

Additional context
The reason this issue occurs is because pkg/support/support.go's getArch function calls uname on the host system, and Windows does not have a uname executable.

getArch should be scoped to OS-specific files for UNIX and Windows.

To help debug the issue as quickly as possible, we recommend generating a support bundle with finch support-bundle generate and attaching it to this issue. This packages all Finch-related configs and logs into one file.
@pendo324 pendo324 added the bug Something isn't working label Apr 12, 2024
@haytok haytok self-assigned this Jun 10, 2024
haytok added a commit to haytok/finch that referenced this issue Jun 12, 2024
@haytok
fix: Enable finch support-bundle generate to execute on Windows whe…
ccd4d56 
…re the `uname` command does not exist

On Windows environments where the `uname` command is not available,
executing `finch support-bundle generate` results in the following error:

```
C:\Users\simpl>"..\..\Program Files\Finch\bin\finch.exe" support-bundle generate
time="2024-06-11T23:21:16+09:00" level=info msg="Generating support bundle..."
time="2024-06-11T23:21:16+09:00" level=fatal msg="exec: \"uname\": executable file not found in %PATH%"
```

This bug has been reported in the following issue:

- runfinch#897

Therefore, this fix enables the execution of
`finch support-bundle generate` even when the `uname` command is not
available on Windows.

Signed-off-by: Hayato Kiwata <[email protected]>
@haytok haytok mentioned this issue Jun 12, 2024
Merged
1 task
pendo324 pushed a commit that referenced this issue Jun 20, 2024
@haytok
fix: Enable finch support-bundle generate to execute on Windows whe… (
9c1caf0 
#976)

…re the `uname` command does not exist

On Windows environments where the `uname` command is not available,
executing `finch support-bundle generate` results in the following
error:

```
C:\Users\simpl>"..\..\Program Files\Finch\bin\finch.exe" support-bundle generate
time="2024-06-11T23:21:16+09:00" level=info msg="Generating support bundle..."
time="2024-06-11T23:21:16+09:00" level=fatal msg="exec: \"uname\": executable file not found in %PATH%"
```

This bug has been reported in the following issue:

- #897

Therefore, this fix enables the execution of
`finch support-bundle generate` even when the `uname` command is not
available on Windows.

Issue #, if available: #897

*Description of changes:* The details are described in this commit
message.

*Testing done:* Yes



- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Hayato Kiwata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haytok haytok

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pendo324 @haytok