Github Checks Interface Setup #2217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fmt and lint checks.
* [ORCA-393] Add basic stats. * Fmt.
To allow for parallel plans per project we will clone the repository per project. Another optimisation we can perform is to copy the default repository that is cloned regardless of the execution type. Default workspace is required to be cloned to setup the project configs.
* Remove mod=vendor from action. * Update workflow to use latest testing env.
* Adding CommandLocker to boltDB and exposing it through locker interface * Apply lock ui and apply command lock controller * Minor comments * Adding more tests and refactorinng * Linting fixes * creating applyLockingClient variable to fix interface error * nullsink for stats * Addressing PR comments * fixing e2e tests * linting fix fml * Update outdated function descriptions Address PR comments * revert stats sink changes
* Add pull closed metrics. * Fix image.
* Remove all unnecessary actions. * Fix test env.
* Current progress * Websocket implementation * Fixing routes * Adding url * Fixed websocket connection * Progress 7/9 * UI Fixes * Fixed test * Fixing failed tests * Update server/controllers/templates/web_templates.go Co-authored-by: Sarvar Muminov <[email protected]> * Update server/events/models/models.go Co-authored-by: Sarvar Muminov <[email protected]> Co-authored-by: Isata Sankoh <[email protected]> Co-authored-by: Isata Sankoh <[email protected]>
* Current progress * Websocket implementation * Fixing routes * Adding url * Fixed websocket connection * Progress 7/9 * Added some channel logic * Changes to models.go * Working on log streaming for plan * Beginning tests/Having errors * Log Streaming Logic * fixed test * Added Testing * Fixed websocket connection * Async implementation and test error fixes * Changes to variables in tests * Debugging * Fixed UI in webpage terminal * Fixing Run make-test coverage * Fixing tests * Testing * Deleted txt.act files * Fixing broken tests * Changes to terraform_client testing * Fixed tests in terraform_client_internal_test.go * Fixed failing test * Deleted lines causing test to fail * Reformating * More Reformatting * Run make check-lint corrections * Added error check * Fixing check-lint test * Suggested changes prior to merge Co-authored-by: Isata Sankoh <[email protected]>
* Thread ctx through to the command runner. * Pass in logger to asyncautoplanner.
* remove TFE flags * Remove `Flag` from EnablePolicyChecks * remove skip-no-clone-changes flag * remove disable-repo-locking flag also addressed e2e tests * removed deprecated flags flags are --require-approval, --require-megreable and other apply requirements flags that should be defined in the server side repo config * Remove GlobalCfgArgs * remove DeleteSourceBranchOnMerge flag * remove --enable-policy-checks flag Instead of using the flag, config will dynamically enable policy checks when it detects policy sets in the server config
|
please fix the conflicts @Aayyush |
|
Closing as not planed |
|
This looks related to #936 |
|
@Aayyush if you can please fix the conflicts, we'd appreciate it. |
|
If anyone is interested in this work can open a new PR based on the lyft fork where this feature was added but the lyft fork has deviated too much from the original atlantis repo. closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add support for using github checks in the plan, apply and policy check workflows. In order to minimize changes to the generic client interface, we delegate the github client's
UpdateStatus()method toPullStatusCheckUpdater(updates the status checks in the Pull Request) andGithubStatusCheckUpdater(updates the github status checks)In addition, we add a new implementation of
CommitStatusUpdaterthat is configured to use the Github Status Checks to update project status instead of the default one - pull request status checks.TODO:
GithubCheckStatusUpdater.UpdateStatus()Relates to #936