Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date filtering for SlackReader #692

Merged
merged 4 commits into from
Mar 11, 2023
Merged

Add date filtering for SlackReader #692

merged 4 commits into from
Mar 11, 2023

Conversation

strickvl
Copy link
Contributor

I added the ability to filter slack messages by date.

Context: was hitting API rate limiting fairly often, and also limits to the amount of documents that my index could ingest.

@strickvl strickvl changed the title Add date filtering for slack messages Add date filtering for SlackReader Mar 10, 2023
Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! @strickvl since this is in the core repo atm, could you use gpt_index imports instead of llama_index?

gpt_index/readers/slack.py Show resolved Hide resolved
@jerryjliu
Copy link
Collaborator

this is great! @strickvl since this is in the core repo atm, could you use gpt_index imports instead of llama_index?

i'll help migrate the reader to llamahub

@strickvl strickvl requested a review from jerryjliu March 11, 2023 07:49
Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet thanks!

@jerryjliu jerryjliu merged commit 37b752d into run-llama:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants