Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the expression construction of Milvus vector store #13591

Merged
merged 2 commits into from
May 20, 2024

Conversation

RussellLuo
Copy link
Contributor

Description

This PR tries to fix #13581.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 20, 2024
@@ -50,15 +50,16 @@ def extract_host_port(url):
return host, port


def _to_milvus_filter(standard_filters: MetadataFilters) -> List[str]:
def _to_milvus_filter(standard_filters: MetadataFilters) -> str:
"""Translate standard metadata filters to Milvus specific spec."""
filters = []
for filter in standard_filters.legacy_filters():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future note, using legacy_filters() here means it will only support exact match filters (even though there are many many filter types supported in the enums)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 20, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels May 20, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) May 20, 2024 19:49
@logan-markewich logan-markewich merged commit 63a38a8 into run-llama:main May 20, 2024
8 checks passed
@RussellLuo RussellLuo deleted the fix-milvus-expr branch May 21, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Milvus vector database:AttributeError: 'NoneType' object has no attribute 'condition'
2 participants