Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hebrew translation #480

Merged
merged 1 commit into from
Nov 6, 2023
Merged

add hebrew translation #480

merged 1 commit into from
Nov 6, 2023

Conversation

electriquo
Copy link

No description provided.

@electriquo electriquo marked this pull request as ready for review November 6, 2023 08:43
@electriquo
Copy link
Author

@rumboalla thank you for the app! as appreciation, i hope this small contribution would assist in getting more traction :)

@rumboalla rumboalla merged commit db95488 into rumboalla:3.x Nov 6, 2023
1 check failed
@rumboalla
Copy link
Owner

Cheers

@electriquo
Copy link
Author

@rumboalla why did the build failed? anything is can do to fix?

@rumboalla
Copy link
Owner

@rumboalla why did the build failed? anything is can do to fix?

Some languages require more plurals to be added for specific cases.

/home/runner/work/apkupdater/apkupdater/app/src/main/res/values-he/strings.xml:65: Error: For locale "he" (Hebrew) the following quantity should also be defined: two [MissingQuantity]

<plurals name="notification_update_description">
        <item quantity="zero">לא נמצאו עדכונים.</item>
        <item quantity="one">נמצאו %1$d עדכונים.</item>
        <item quantity="other">נמצאו %1$d עדכונים.</item>
    </plurals>

@electriquo
Copy link
Author

electriquo commented Nov 6, 2023

i fixed the "one" for better readability and added "two".

<plurals name="notification_update_description">
        <item quantity="zero">לא נמצאו עדכונים.</item>
        <item quantity="one">נמצא עדכון.</item>
        <item quantity="two">נמצאו 1$d עדכונים.</item>
        <item quantity="other">נמצאו 1$d עדכונים.</item>
</plurals>

i hope this will fix the build process. if it is not hard for you, would appreciate if you could incorporate the changes. otherwise, please do tell and i will open a PR.

@HazakuraID
Copy link
Contributor

HazakuraID commented Nov 7, 2023

what hell. there any wrong code %1$ is not used when typo 1$ letter "d" I don't know translation mistakes you learn.

Try to see your eyes are really focused right now its ( %1$d ) 🤦🏻‍♂️
Edit: forget that % number.

@HazakuraID
Copy link
Contributor

@rumboalla answered correctly it's a case of writing: 1$d

@electriquo
Copy link
Author

electriquo commented Nov 7, 2023

guys, hebrew is right-to-left language. when it is mixed with left-to-write language, the console rendering might not display it correctly. it should be from right-to-left: number then the text.

what hell. there any wrong code %1$ is not used when typo 1$ letter "d" I don't know translation mistakes you learn.
Try to see your eyes are really focused right now its ( 1$d )

in the original code, it is different

<item quantity="one">Found %1$d update.</item>

if you will render the following from right to left (github renders it incorrectly), it should be as follows

1$d עדכונים נמצאו

reminding you that it was open for a review, but thank you for being nice :)

i also took the care to fix the snippet in #480 (comment).

i hope this will fix the build process. if it is not hard for you, would appreciate if you could incorporate the changes. otherwise, please do tell and i will open a PR.

@rumboalla your answer please?

@rumboalla
Copy link
Owner

Should be fixed now, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants