-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hebrew translation #480
Conversation
@rumboalla thank you for the app! as appreciation, i hope this small contribution would assist in getting more traction :) |
Cheers |
@rumboalla why did the build failed? anything is can do to fix? |
Some languages require more plurals to be added for specific cases. /home/runner/work/apkupdater/apkupdater/app/src/main/res/values-he/strings.xml:65: Error: For locale "he" (Hebrew) the following quantity should also be defined: two [MissingQuantity]
|
i fixed the "one" for better readability and added "two". <plurals name="notification_update_description">
<item quantity="zero">לא נמצאו עדכונים.</item>
<item quantity="one">נמצא עדכון.</item>
<item quantity="two">נמצאו 1$d עדכונים.</item>
<item quantity="other">נמצאו 1$d עדכונים.</item>
</plurals> i hope this will fix the build process. if it is not hard for you, would appreciate if you could incorporate the changes. otherwise, please do tell and i will open a PR. |
what hell. there any wrong code %1$ is not used when typo 1$ letter "d" I don't know translation mistakes you learn. Try to see your eyes are really focused right now its ( %1$d ) 🤦🏻♂️ |
@rumboalla answered correctly it's a case of writing: 1$d |
guys, hebrew is right-to-left language. when it is mixed with left-to-write language, the console rendering might not display it correctly. it should be from right-to-left: number then the text.
in the original code, it is different
if you will render the following from right to left (github renders it incorrectly), it should be as follows
reminding you that it was open for a review, but thank you for being nice :) i also took the care to fix the snippet in #480 (comment).
@rumboalla your answer please? |
Should be fixed now, thanks |
No description provided.