Allow url generation for changed files #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 7, 2021
ruifm
commented
Jul 8, 2021
Comment on lines
+89
to
+98
| if not git.has_file_changed(buf_path, rev) then | ||
| range = buffer.get_range(mode, user_opts.add_current_line_on_normal_mode) | ||
| elseif mode == "v" or user_opts.add_current_line_on_normal_mode then | ||
| print( | ||
| string.format( | ||
| "No line numbers were computed because '%s' has changes", | ||
| buf_path | ||
| ) | ||
| ) | ||
| end |
There was a problem hiding this comment.
Here I should also check if the buffer has been modified but not written to.
The downside is that it would fail in the edge case scenario where the buffer is modified, written, and then modified in such a way that it reverts it back to the original state (e.g. using undo), which means that the current buffer contents are unmodified with respect to its remote counterpart, whereas the working directory version is not.
stevanmilic
pushed a commit
to stevanmilic/gitlinker.nvim
that referenced
this pull request
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21