Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update translations #17147

Merged
merged 1 commit into from
Jul 22, 2024
Merged

chore: Update translations #17147

merged 1 commit into from
Jul 22, 2024

Conversation

RuffleBuild
Copy link

New Crowdin pull request with translations

@torokati44
Copy link
Member

Could you please review, @sombraguerrero?

@torokati44
Copy link
Member

Hmh, checks are not running again, @Dinnerbone ... 🤔
Does rebasing work differently in this regard from creating the PR...?

@Dinnerbone
Copy link
Contributor

There was a github outage last night, maybe?

@torokati44
Copy link
Member

Hmh... Re-ran the job from last night, hence the force push, but still no checks running. le sigh

@Dinnerbone
Copy link
Contributor

Try another pr to check? There's nothing special about this PR, especially if you are the one to hit rebase.

@torokati44
Copy link
Member

especially if you are the one to hit rebase.

nah, 'twas the GHA workflow. no rebase button if it's already on top of HEAD unforty

@Dinnerbone
Copy link
Contributor

You said you force pushed...?

@torokati44
Copy link
Member

Could you please review, @sombraguerrero?

I meant the one Spanish translation only, of course... MT/AI stuff didn't convince me that it's right.

You said you force pushed...?

I pressed "Re-run" on the same job that ran yesterday evening. It usually works to update the contents of translations from CrowdIn after hotfixing/undoing something.

@Dinnerbone
Copy link
Contributor

I guess the push itself needs to happen with the token, not just making the PR?

@torokati44
Copy link
Member

maybe!

@Dinnerbone
Copy link
Contributor

The crowdin action uses git push, so I guess we need to find a way to change what credentials that uses

@github-actions github-actions bot force-pushed the l10n_crowdin_translations branch 2 times, most recently from ee3c5ea to 0289595 Compare July 21, 2024 21:05
{ $variant ->
*[unsupported] Tarayıcınız tam panoya erişimi desteklemiyor,
[access-denied] Pano erişimi reddedildi,
} ancak pano yerine her zaman bu kısayolları kullanabilirsiniz:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"instead of the clipboard"...?

@torokati44
Copy link
Member

Eh, even if the Spanish and Turkish translations may not be the best, they can most likely be understood. They can always be fixed later.

@torokati44 torokati44 enabled auto-merge (rebase) July 22, 2024 17:31
@torokati44 torokati44 merged commit db1e420 into master Jul 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants