debug_ui: Improve debug rect bounds calculation & draw bounds on hover #16926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, it was possible that some objects did not have a debug rect despite existing on the stage and interacting with the user. That was the case for instance for buttons with hit bounds and no up state. This patch ensures that debug rect is at least as big as highlight bounds, which are used to highlight focused objects on the stage.
When the user hovers on world bounds and highlight bounds, debug rects signifying their positions are automatically drawn.
Dinnerbone
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, it was possible that some objects did not have a debug rect despite existing on the stage and interacting with the user. That was the case for instance for buttons with hit bounds and no up state (see for instance #16921).
This patch ensures that debug rect is at least as big as highlight bounds, which are used to highlight focused objects on the stage.
Additionally, when the user hovers on world bounds and highlight bounds, debug rects signifying their positions are automatically drawn in order to visualize their positions on the stage.