Refactor main flow and make small fixes in other flows #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
radyslavkrechet
commented
Feb 1, 2018
radyslavkrechet
commented
- refactor code with new code style guidelines
- rename views protocol's name
- replace data source and delegate classes with provider classes
AntonoffEvgeniy
suggested changes
Feb 1, 2018
| weak var controllerDelegate: ImagesCarouselViewControllerProtocol? | ||
| private var collectionProvider: ImagesCarouselCollectionProvider! | ||
|
|
||
| var showingIndex: Int = 0 | ||
|
|
||
| var images = [Image]() { |
There was a problem hiding this comment.
Change to var images: [Image] = []
|
|
||
| let headerNib = UINib(nibName: String(describing: ProductOptionHeaderView.self), bundle: nil) | ||
| collectionView.register(headerNib, forSupplementaryViewOfKind: UICollectionElementKindSectionHeader, withReuseIdentifier: String(describing: ProductOptionHeaderView.self)) | ||
| let headName = String(describing: ProductOptionHeaderView.self) |
There was a problem hiding this comment.
headerName instead of headName
|
|
||
| func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int { | ||
| switch section { | ||
| case HomeSection.lastArrivals.rawValue: |
There was a problem hiding this comment.
We can concatenate case HomeSection.lastArrivals.rawValue and case HomeSection.popular.rawValue
| strongSelf.data.value = (latestProducts, popularProducts, articles) | ||
| } | ||
| strongSelf.state.onNext(.content) | ||
| }, onError: { [weak self] (error) in |
There was a problem hiding this comment.
I think the wrong tabulation here
There was a problem hiding this comment.
Unfortunately, there is a default Xcode's spacing.
plzen
approved these changes
Feb 1, 2018
AntonoffEvgeniy
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.