Refactor base module, cart and account flows #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonoffEvgeniy
approved these changes
Jan 26, 2018
AntonoffEvgeniy
approved these changes
Jan 29, 2018
plzen
reviewed
Jan 29, 2018
| selectedOrder = viewModel.items.value[index] | ||
| performSegue(withIdentifier: SegueIdentifiers.toOrderDetails, sender: self) | ||
| extension OrdersListViewController: OrdersListTableProviderDelegate { | ||
| func provider(_ provider: OrdersListTableProvider, didSelectItemAt index: Int) { |
There was a problem hiding this comment.
Maybe it's better to pass certain object instead of index?
There was a problem hiding this comment.
Yes, it makes sense because now we have reference on items.
| guard let productVariant = viewModel.productVariant(at: index) else { | ||
| return | ||
| } | ||
| func provider(_ provider: OrdersDetailsTableProvider, didSelectProductVariant productVariant: ProductVariant) { |
There was a problem hiding this comment.
Maybe better:
func provider(_ provider: OrdersDetailsTableProvider, didSelect productVariant: ProductVariant)
?
AntonoffEvgeniy
approved these changes
Jan 29, 2018
plzen
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.