Fix bugs #67
Merged
Fix bugs #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plzen
suggested changes
Jan 24, 2018
| switch section { | ||
| case HomeSection.lastArrivals.rawValue: | ||
| type = .latestArrivals | ||
| isNeedToHideSeeAllButton = delegate?.lastArrivalsObjectsCount() ?? 0 < kItemsPerPage ? true : false |
There was a problem hiding this comment.
You don't need ternary operator here, just use delegate?.lastArrivalsObjectsCount() ?? 0 < kItemsPerPage
| default: | ||
| type = .blogPosts | ||
| isNeedToHideSeeAllButton = delegate?.articlesCount() ?? 0 < kItemsPerPage ? true : false |
There was a problem hiding this comment.
You don't need ternary operator here, just use delegate?.articlesCount() ?? 0 < kItemsPerPage
AntonoffEvgeniy
suggested changes
Jan 24, 2018
| updateCustomer(with: query, callback: callback) | ||
| updateCustomer(with: query) { [weak self] (customer, error) in | ||
| if customer != nil { | ||
| self?.updateSessionDate(with: email) |
There was a problem hiding this comment.
By our styleguide (https://github.com/plzen/styleguides/blob/master/ios/STYLEGUIDE.md#memory-management) we need to use:
guard let strongSelf = self else {
return
}
strongSelf.updateSessionDate(with: email)
instead of:
self?.updateSessionDate(with: email)
plzen
approved these changes
Jan 26, 2018
AntonoffEvgeniy
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One commits name = one description of bug fixes