Feature/add controller lce states #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plzen
suggested changes
Nov 7, 2017
| var refreshControl: UIRefreshControl? | ||
|
|
||
| override func viewDidLoad() { |
| import RxSwift | ||
|
|
||
| class ArticleDetailsViewModel: BaseViewModel { | ||
| var articleId = String() |
There was a problem hiding this comment.
Remove default initializer for this variable. We don't need to call API with empty string.
| @@ -8,78 +8,60 @@ | |||
|
|
|||
| import UIKit | |||
|
|
|||
| class CategoryViewController: GridCollectionViewController, SortModalControllerProtocol { | |||
| class CategoryViewController: GridCollectionViewController<CategoryViewModel>, SortModalControllerProtocol { | |||
| var categoryId = String() | |||
There was a problem hiding this comment.
Remove default initializer for this variable. We don't need to call API with empty string.
| import RxSwift | ||
|
|
||
| class CategoryViewModel: GridCollectionViewModel { | ||
| var categoryId = String() |
There was a problem hiding this comment.
Remove default initializer for this variable. We don't need to call API with empty string.
| @@ -20,52 +20,59 @@ class ProductDetailsViewController: UIViewController, ImagesCarouselViewControll | |||
| @IBOutlet weak var optionsContainerViewHeightConstraint: NSLayoutConstraint! | |||
|
|
|||
| var productId = String() | |||
There was a problem hiding this comment.
Remove default initializer for this variable. We don't need to call API with empty string.
| var product = Variable<Product?>(nil) | ||
| var selectedVariant = PublishSubject<SelectedVariant>() | ||
|
|
||
| var productId = String() |
There was a problem hiding this comment.
Remove default initializer for this variable. We don't need to call API with empty string.
plzen
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LCE base controller
Added error, loading views