Feature/account screen authorized #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plzen
suggested changes
Dec 12, 2017
| } | ||
|
|
||
| private func populateViews(customer: Customer) { | ||
| let customerName = "\(customer.firstName ?? String()) \(customer.lastName ?? String())" |
There was a problem hiding this comment.
Use translation with 2 params and pass first and last name
| @@ -13,10 +13,13 @@ protocol AccountTableDelegateProtocol { | |||
| func customer() -> Customer? | |||
| } | |||
|
|
|||
| private let kHeaderHeightLogged: CGFloat = 184 | |||
There was a problem hiding this comment.
Try to avoid hardcoded height for header. Looks like we can use 0 for estimated height and it should fit to header content
plzen
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added authorized header view to account screen