Add shop configs #179
Merged
Add shop configs #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/magento #179 +/- ##
===================================================
- Coverage 85.2% 85.12% -0.08%
===================================================
Files 265 266 +1
Lines 7083 7155 +72
===================================================
+ Hits 6035 6091 +56
- Misses 1048 1064 +16
|
plzen
suggested changes
Jun 7, 2018
| @IBOutlet private weak var tableView: UITableView! | ||
|
|
||
| private var selectedPolicy: Policy? | ||
|
|
||
| var tableProvider: AccountTableProvider! | ||
| var isOrdersEnabled: Bool! |
There was a problem hiding this comment.
You inject this value to view controller and then pass it to the provider, but you can inject it directly to a provider
| @@ -19,6 +19,8 @@ class HomeViewController: BaseTableViewController<HomeViewModel>, HomeTableProvi | |||
| private var selectedArticle: Article? | |||
|
|
|||
| var tableProvider: HomeTableProvider! | |||
| var isPopularEnabled: Bool! | |||
There was a problem hiding this comment.
The same here, just inject config values to providers
plzen
approved these changes
Jun 7, 2018
| func provider(_ provider: AccountTableProvider, didSelect policy: Policy) | ||
| } | ||
|
|
||
| class AccountTableProvider: NSObject, UITableViewDataSource, UITableViewDelegate { | ||
| private let kSpaceBetweenSections: CGFloat = 10 |
There was a problem hiding this comment.
private let properties inside class should not have prefix 'k'
AntonoffEvgeniy
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.