Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cart api protocol #178

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Add cart api protocol #178

merged 1 commit into from
Jun 6, 2018

Conversation

AntonoffEvgeniy
Copy link
Contributor

No description provided.

@AntonoffEvgeniy AntonoffEvgeniy changed the title Add cart api Add cart api protocol Jun 5, 2018
@codecov
Copy link

codecov bot commented Jun 5, 2018

Codecov Report

Merging #178 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #178      +/-   ##
===========================================
+ Coverage     84.5%   84.54%   +0.04%     
===========================================
  Files          238      229       -9     
  Lines         5918     5727     -191     
===========================================
- Hits          5001     4842     -159     
+ Misses         917      885      -32
Impacted Files Coverage Δ
ShopApp_Gateway/Adapters/CartProductAdapter.swift 100% <100%> (ø)
...ules/Main/ViewModels/ProductDetailsViewModel.swift 91.46% <100%> (ø) ⬆️
...pApp/Data/Repositories/ShopAppCartRepository.swift 100% <100%> (ø) ⬆️

@@ -156,3 +156,20 @@ class ProductDetailsViewModel: BaseViewModel {
loadData()
}
}

private class CartProductAdapter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this adapter from view model to gateway.

@plzen plzen merged commit f7b1a5b into develop Jun 6, 2018
@plzen plzen deleted the feature/cart_api branch June 6, 2018 12:56
plzen pushed a commit that referenced this pull request Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants