Add get categories api #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plzen
suggested changes
May 10, 2018
| public func getCategoryList(perPage: Int, paginationValue: Any?, sortBy: SortingValue?, reverse: Bool, callback: @escaping RepoCallback<[ShopApp_Gateway.Category]>) { | ||
| // TODO: Implement api method | ||
| callback([], nil) | ||
| public func getCategoryList(perPage: Int, paginationValue: Any?, sortBy: SortingValue?, reverse: Bool, rootCategoryId: String?, callback: @escaping RepoCallback<[ShopApp_Gateway.Category]>) { |
There was a problem hiding this comment.
Can we avoid passing rootCategoryId for each request? I think we can pass it to MagentoApi class
AntonoffEvgeniy
approved these changes
May 10, 2018
| if let sortBy = sortBy { | ||
| switch sortBy { | ||
| case .name: | ||
| fieldName = nameField |
There was a problem hiding this comment.
Double space in this line
| case .createdAt: | ||
| fieldName = createdAtField | ||
| case .priceHighToLow, .priceLowToHigh: | ||
| fieldName = priceField |
There was a problem hiding this comment.
Double space in this line
radyslavkrechet
force-pushed
the
categories-api
branch
from
b2f465b
to
341a5cf
Compare
Codecov Report
@@ Coverage Diff @@
## feature/magento #169 +/- ##
===================================================
+ Coverage 60.43% 73.9% +13.47%
===================================================
Files 261 264 +3
Lines 6902 7024 +122
===================================================
+ Hits 4171 5191 +1020
+ Misses 2731 1833 -898
|
AntonoffEvgeniy
approved these changes
May 25, 2018
AntonoffEvgeniy
pushed a commit
that referenced
this pull request
May 29, 2018
* Add get categories api * Add tests for models * Add tests for adapters * Add session service tests * Add parameters builder and routers tests * Add base api tests * Add magento api tests
AntonoffEvgeniy
pushed a commit
that referenced
this pull request
May 29, 2018
* Add get categories api * Add tests for models * Add tests for adapters * Add session service tests * Add parameters builder and routers tests * Add base api tests * Add magento api tests
plzen
pushed a commit
that referenced
this pull request
Jun 8, 2018
* Add get categories api * Add tests for models * Add tests for adapters * Add session service tests * Add parameters builder and routers tests * Add base api tests * Add magento api tests
plzen
pushed a commit
that referenced
this pull request
Jun 12, 2018
* Add get categories api * Add tests for models * Add tests for adapters * Add session service tests * Add parameters builder and routers tests * Add base api tests * Add magento api tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.