Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil request in Exchange#navigation_request? #339

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

francisbeaudoin
Copy link
Contributor

Details

As the Exchange object is pushed to the network traffic before assigning its request, it is assumed that the request can be nil in the exchange object.

exchange = select(request.id).last
exchange = build_exchange(request.id) unless exchange&.blank?

exchange.request = request

For that reason, the #navigation_request? method was updated to be nil safe.

@route route merged commit 0cab51d into rubycdp:main Feb 11, 2023
@francisbeaudoin francisbeaudoin deleted the fix-exchange-navigation-request-nil branch February 15, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants