Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed config param being sent to DRb.auto_load since its unused. #515

Closed

Conversation

vipulnsward
Copy link

removed config param being sent to DRb.auto_load since its unused.

return uri_option(uri, config, false)
end
raise DRbBadURI, 'can\'t parse uri:' + uri
end
module_function :uri_option

def auto_load(uri, config) # :nodoc:
def auto_load(uri) # :nodoc:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it broke to backward compatibility.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsbt would you suggest deprecating this first?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its up to @seki

@hsbt hsbt closed this in 837d303 Jan 4, 2015
ayumin pushed a commit to ayumin/ruby that referenced this pull request Jan 4, 2015
  [fix rubyGH-515]

git-svn-id: svn+ssh:https://ci.ruby-lang.org/ruby/trunk@49130 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mmasaki pushed a commit to mmasaki/ruby that referenced this pull request May 30, 2015
  [fix rubyGH-515]

git-svn-id: svn+ssh:https://ci.ruby-lang.org/ruby/trunk@49130 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@eregon eregon mentioned this pull request Dec 16, 2015
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants