Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #3242] Ignore cache files disappearing during cleanup even more #3975

Merged
merged 1 commit into from
Jan 28, 2017

Conversation

mikegee
Copy link
Contributor

@mikegee mikegee commented Jan 26, 2017

We already ignore Errno::ENOENT during cache cleanup, but File.mtime might raise too.

fixes #3242


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@mikegee mikegee changed the title [Fix #3242] Ignore files disappearing even more [Fix #3242] Ignore cache files disappearing during cleanup even more Jan 26, 2017
We already ignore `Errno::ENOENT` during the removal, but `File.mtime`
might raise too.
@bbatsov bbatsov merged commit 1c0cf57 into rubocop:master Jan 28, 2017
@mikegee mikegee deleted the fix3242 branch January 28, 2017 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup isn't concurrent-safe
2 participants