Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make yield is not complex in Style/TernaryParentheses cop #3949

Merged
merged 1 commit into from
Jan 22, 2017

Conversation

onk
Copy link
Contributor

@onk onk commented Jan 21, 2017

yield is simple enough.

# EnforcedStyle: require_parentheses_when_complex
#
# # bad
# foo = (yield) ? a : b
#
# # good
# foo = yield ? a : b

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

```
# EnforcedStyle: require_parentheses_when_complex
#
# # bad
# foo = (yield) ? a : b
#
# # good
# foo = yield ? a : b
```
@bbatsov bbatsov merged commit c500b3c into rubocop:master Jan 22, 2017
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 22, 2017

👍

@onk onk deleted the feature/ternary_parentheses_with_yield branch January 22, 2017 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants