Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in the documentation for some Rails cops #3943

Merged
merged 1 commit into from
Jan 21, 2017
Merged

Fix typo in the documentation for some Rails cops #3943

merged 1 commit into from
Jan 21, 2017

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented Jan 20, 2017

Rails/Date and Rails/TimeZone cops support flexible style.

However, in the documentation, the style is acceptable.
This change fixes the mismatch.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@bbatsov bbatsov merged commit b1d5e4a into rubocop:master Jan 21, 2017
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 21, 2017

👍

@pocke pocke deleted the s/acceptable/flexible branch January 21, 2017 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pocke @bbatsov