Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Docusaurus #21

Merged
merged 6 commits into from
Nov 15, 2020
Merged

Docusaurus #21

merged 6 commits into from
Nov 15, 2020

Conversation

msutkowski
Copy link
Member

Major WIP 😅

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit abac1c7:

Sandbox Source
React Configuration
React Typescript Configuration
rtk-simple-query-demo Configuration
svelte-app-rtk-simplequery-demo Configuration

@markerikson
Copy link
Collaborator

where you planning on hosting this? just grab a Netlify-labeled subdomain or something? Can set one up tied to the Redux Netlify team if you want.

@msutkowski
Copy link
Member Author

@markerikson Exactly. I setup Netlify and such last night, and was going to do the .js.org thing later today. If you wanna help out with that, I'd appreciate it because the goal was just to get it up -> transition over to your accounts as an offical redux/rtk thing when you wanted.

@markerikson
Copy link
Collaborator

@msutkowski I would actually vote that we not bother with a .js.org name for now. Takes some time to add one of those, and assuming this new API works out, eventually we'd want to migrate the content into the actual RTK docs.

I'd say for this "incubator" stuff, it's better to just go with a generic Netlify-hosted name, like rtk-query-docs.netlify.app or something.

@msutkowski
Copy link
Member Author

Sounds good to me. I'm assuming you've already got the OSS Netlify account, so if you want to add it, that'd be great.

@markerikson
Copy link
Collaborator

markerikson commented Nov 13, 2020

okay, set up the Netlify site, as https://rtk-query-docs.netlify.app/

Not sure what the build command and output folder are atm. You may want to go copy-paste a netlify.toml file from one of the Redux repos, paste it in here, and edit the settings - I believe that config file overrides whatever build settings are in the Netlify dashboard.

@markerikson
Copy link
Collaborator

aaaand we have build preview!

https://deploy-preview-21--rtk-query-docs.netlify.app/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 15, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 12168c8:

Sandbox Source
React Configuration
React Typescript Configuration
rtk-simple-query-demo Configuration
svelte-app-rtk-simplequery-demo Configuration

@markerikson
Copy link
Collaborator

We should get the TS/JS conversion plugin ported over from the RTK docs.

Also, use the new Markdown code block title syntax for code block filenames, instead of comments, like:

```js title="src/someFile.ts"

@markerikson
Copy link
Collaborator

Let's merge this in and iterate on it.

@markerikson markerikson marked this pull request as ready for review November 15, 2020 17:09
@markerikson markerikson merged commit d3ce4f7 into rtk-incubator:main Nov 15, 2020
@msutkowski msutkowski deleted the docusaurus branch November 15, 2020 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants