-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f075099:
|
c603061
to
09fe62a
Compare
size-limit report 📦
|
6f305a4
to
cd1a655
Compare
cd1a655
to
fc27ae7
Compare
fc27ae7
to
d504d07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will require updates in the docs that were merged: https://github.com/rtk-incubator/rtk-query/pull/191/files#diff-b2cf37354c870ebf35a4045446fae1006ca83193784282bb2066da6bba8a1f91R94, but was introduced for consistency with the other hook names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already said it in chat - I think we don't need the fancy type overloading here as we don't really have a use for isFetching
in mutations.
My change suggestions might be a bit sloppy, I'm not feeling so well 🙃
Co-authored-by: Lenz Weber <[email protected]>
1f74935
to
94689bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mini nitpicks, then this can go in :)
Co-authored-by: Lenz Weber <[email protected]>
Deploy preview for rtk-query-docs ready! Built with commit f075099 |
* Add selectFromResult as an option to the useMutation hook * Update UseMutation return type and tests Co-authored-by: Lenz Weber <[email protected]>
selectFromResult
option foruseMutation()
.requestId
. For the most performant implementation, you canyourEndpoint.useMutation(undefined, { selectFromResult: () => ({}) })