Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams with spaces in their name lead to all sorts of problems #51

Closed
ohumbel opened this issue Aug 31, 2015 · 3 comments
Closed

Streams with spaces in their name lead to all sorts of problems #51

ohumbel opened this issue Aug 31, 2015 · 3 comments
Labels

Comments

@ohumbel
Copy link
Member

ohumbel commented Aug 31, 2015

While the lscm/scm commands are properly quoted, the following problems still exist:

  • history files are not found
  • git branches get an invalid name
History file not found: ~/rtc2git/History/History_BT_Spider_'Cross main stream'.txt

Executed Command: "git show-ref --verify --quiet refs/heads/'Cross main stream'"
fatal: 'Cross main stream' is not a valid branch name.

Executed Command: "git push origin 'Cross main stream'_branchpoint"
fatal: 'Cross main stream_branchpoint' is not a valid branch name.
fatal: remote part of refspec is not a valid name in Cross main stream_branchpoint
@ohumbel ohumbel added the bug label Aug 31, 2015
@ohumbel
Copy link
Member Author

ohumbel commented Aug 31, 2015

Obviously, git branches must not contain spaces.
On the other hand, the tool relies on
streamname == branchname
in many places.
To really solve this problem, we would need to carry a
streamname -> branchname conversion table
all around.

A quick fix would be to stop the migration in this case, and inform the user to rename the stream in RTC.

ohumbel added a commit to ohumbel/rtc2git that referenced this issue Aug 31, 2015
If a stream name would lead to invalid git branch names, abort the migration and suggest renaming the stream.
Fixes rtcTo#51.
@WtfJoke
Copy link
Member

WtfJoke commented Sep 1, 2015

It got closed automatically with the merge of the pr. Do we want to investigate further or should I leave it closed?

@ohumbel
Copy link
Member Author

ohumbel commented Sep 1, 2015

I suggest we leave it closed and investigate further as soon as someone really has a problem with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants