Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start v1.8.1.1 release candidate #4020

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Start v1.8.1.1 release candidate #4020

merged 4 commits into from
Apr 3, 2024

Conversation

cpsievert
Copy link
Collaborator

No description provided.

@cpsievert cpsievert marked this pull request as draft March 29, 2024 18:55
@gadenbuie
Copy link
Member

I know this change is small, but I would like to advocate for us sticking with semantic versioning and calling this v1.8.2 instead of v1.8.1.1. In general, I think it's best to avoid these non-standard version numbers except for the (hopefully very) rare case where we need to both make an out-of-cycle hotfix and have also already moved the version number past the most logical next choice.

@cpsievert
Copy link
Collaborator Author

I think it's best to avoid these non-standard version numbers

Do you have reasoning for this beyond sticking to semantic versioning? This is a practice we've done for quite a while and I do like that the version itself indicates it's a patch release

package.json Outdated Show resolved Hide resolved
@gadenbuie
Copy link
Member

gadenbuie commented Mar 29, 2024

This is a practice we've done for quite a while and I do like that the version itself indicates it's a patch release

I mean, the version format is <major>.<minor>.<patch> so in that regard it's not really a patch release – at least not in the semantic versioning format. semver.org guidelines include pre-release and build information, but those are separated from the version number by -<pre-release> and +<build>.

I think that it's one thing to step out of semver because we're forced to push a hotfix to CRAN that we hadn't accounted for, but we should adhere to semver as much as possible. In this case, nothing is forcing us to add a non-standard version component.

@cpsievert
Copy link
Collaborator Author

I'll let @wch have final say on the version (we had both agreed that 1.8.1.1 was more appropriate)

@cpsievert cpsievert requested a review from wch March 29, 2024 22:02
@cpsievert cpsievert marked this pull request as ready for review April 3, 2024 14:25
@cpsievert cpsievert merged commit 5e566a0 into main Apr 3, 2024
30 of 45 checks passed
@cpsievert cpsievert deleted the rc-v1.8.1.1 branch April 3, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants