This repository has been archived by the owner on Jan 5, 2021. It is now read-only.
Use content_by_lua and access_by_lua instead of by_file #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbarraford
added a commit
that referenced
this pull request
Nov 18, 2014
Use content_by_lua and access_by_lua instead of by_file
|
Does this restart the LUA VM every request? |
|
nope |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a bug where if you use
content_by_lua_fileinstead ofcontent_by_lua, the lua vm leaks memory until it crashes.In dev, i could run a bash for loop hitting
/batchapi endpoint and see memory utilization would go up until the VM crashes (about 1GB). Even if i ran garbage collection manually, it would help but never get back to less than hundreds of MBs.Using the new way, i was unable to get memory utilization of the VM to go above 1 or 2 MBs.