Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery dependency #28

Merged
merged 3 commits into from
Mar 26, 2014
Merged

Remove jQuery dependency #28

merged 3 commits into from
Mar 26, 2014

Conversation

rferri
Copy link
Contributor

@rferri rferri commented Aug 28, 2013

Addresses #7 (jQuery independence) and #17 (vendor prefixes).

DOM helpers added:

addClass(element, class)
removeClass(element, class)
hasClass(element, class)
classList(element)
removeElement(element)

CSS helpers added:

css(element, property, value)
css(element, properties)

Queue helper added:

queue(fn) // fn accepts a next callback to continue the queue

Should be a good start, there's bound to be something I've missed.

@caarlos0
Copy link

👍

1 similar comment
@netpoetica
Copy link

+1

goffrie
goffrie reviewed Aug 28, 2013
View reviewed changes
nprogress.js
define(['jquery'], function($) {
return factory($);
define(function() {
return factory();
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define(factory);?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call 👍

@lancepioch
Copy link

👍

@mparramont
Copy link

Go!

@styfle
Copy link

styfle commented Aug 30, 2013

+1 👍

@duncanmcdowell
Copy link

Awesome - working for me on 1.7.x

@j1n6
Copy link

j1n6 commented Sep 2, 2013

this is awesome!

@hauleth
Copy link

hauleth commented Sep 15, 2013

👍 libraries like this should be independent as much as possible.

@caiotarifa
Copy link

👍

@rstacruz
Copy link
Owner

rstacruz commented Oct 4, 2013

Cool, let me try to review this in the coming days. cheers!

@bettiolo
Copy link

This is a very good idea

@ravenjohn
Copy link

👍 I just used this last hackathon.

@jtdroste
Copy link

jtdroste commented Feb 8, 2014

Any updates on merging this?

@TimPetricola
Copy link

👍

@ghost
Copy link

ghost commented Feb 14, 2014

Yes, please make this a vanilla JavaScript library. Thanks!

@vietqhoang
Copy link

+1 for merging this and removing the jquery dependency.

rstacruz added a commit that referenced this pull request Mar 26, 2014
@rstacruz
Merge pull request #28 from rurjur/vanilla
fbddeec 
Remove jQuery dependency
@rstacruz rstacruz merged commit fbddeec into rstacruz:master Mar 26, 2014
@rstacruz
Copy link
Owner

Thanks! Sorry this took a while.

@rstacruz
Copy link
Owner

Out in v0.1.3, thanks @rurjur everyone!

This was referenced Aug 7, 2014
Merged
Closed
@antoniobrandao antoniobrandao mentioned this pull request Nov 1, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet