Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearranging of priority of scripts, bug fixes #68

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Conversation

rsnk96
Copy link
Owner

@rsnk96 rsnk96 commented Jan 27, 2020

  • Shifted ML-Basic to the primary sequence of scripts to be executed and ML-Build (renamed to Build-ML.sh) out of the primary numbered sequence
  • Renamed the ML and opencv building scripts to reflect building of scripts
  • Added pip installation of opencv-contrib-python if opencv isn't already installed either from pip or from source in 3-ML-Basic.sh
  • Removed station from shortcuts
  • Autoinstallation of nvidia drivers if an nvidia graphics card is detected in lspci

* Shifted `ML-Basic` to the primary sequence of scripts to be executed and `ML-Build` (renamed to `Build-ML.sh`) out of the primary numbered sequence
* Renamed the ML and opencv building scripts to reflect building of scripts
* Added `pip` installation of `opencv-contrib-python` if opencv isn't already installed either from pip or from source in `3-ML-Basic.sh`
* Removed station from shortcuts
@rsnk96 rsnk96 requested a review from rajat2004 January 27, 2020 11:35
@rajat2004
Copy link
Collaborator

Changes look good, though I can't test or anything, don't have access to my laptop for the next few days. Additions to the driver and OpenCV installs are great
A thought, should there be something in the OpenCV script also, check if OpenCV is already installed, and then tell the user to uninstall it or do it ourselves?

@rsnk96
Copy link
Owner Author

rsnk96 commented Jan 28, 2020

Merging this then, shifting cv patches to another PR

@rsnk96 rsnk96 merged commit 12fd73c into master Jan 28, 2020
@rsnk96 rsnk96 deleted the shift_script_order branch February 8, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants